privacy: Add publically-reexported foreign item to exported item set #15848
Conversation
| @@ -326,7 +326,8 @@ impl<'a> Visitor<()> for EmbargoVisitor<'a> { | |||
| } | |||
|
|
|||
| fn visit_foreign_item(&mut self, a: &ast::ForeignItem, _: ()) { | |||
| if self.prev_exported && a.vis == ast::Public { | |||
| if (self.prev_exported && a.vis == ast::Public) | |||
| || self.reexports.contains(&a.id) { | |||
There was a problem hiding this comment.
For readability's sake, this should be a single line. The current style rules allow for 99 characters in a line, and this is only 91 characters.
There was a problem hiding this comment.
I personally strive for 80 characters per line, hence the newline. Anyway, commit updated.
There was a problem hiding this comment.
Thanks. I know @alexcrichton also preferred to limit himself to 80 characters when appropriate, but we have recently officially removed the 80/100 split and settled on 99 (although that 99 is not set in stone yet). I wouldn't have said anything except that the line continuation here ended up indented only 1 level, which matches the indentation of the body. If it didn't fit on one line, I would have instead suggested indenting it a second level.
|
Offhand, LGTM. I haven't looked at the privacy code before, but this appears to match the logic used in |
Fix intra doc links Fixes rust-lang#15848
Closes #15740