libsyntax: Disallow struct literals after if, while, match, and
#14885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this update the manual as well? |
|
Updated the manual. r? @nick29581 |
| @@ -1 +1 @@ | |||
| Subproject commit 7b97b8468f0614072cf3299fa8c51e85f609316f | |||
| Subproject commit ed112ca1e4275e1c5707a898f2bf6164707ba378 | |||
There was a problem hiding this comment.
This was reverted by accident I think
|
re-r? @alexcrichton |
`for...in`. Closes rust-lang#14803. If you used a structure literal after one of these keywords, surround it in parentheses. [breaking-change]
bors
added a commit
that referenced
this pull request
Jun 24, 2014
…xcrichton `for...in`. Closes #14803. If you used a structure literal after one of these keywords, surround it in parentheses. [breaking-change] r? @nick29581
| @@ -12,7 +12,7 @@ struct Foo; | |||
|
|
|||
| fn g3() { | |||
| let _mid_tuple = (Foo { }, 2); | |||
| //~^ ERROR: unit-like struct construction is written with no trailing `{ }` | |||
| //~^ ERROR: structure literal must either have at least one field | |||
There was a problem hiding this comment.
English - "either ..." or? should perhaps be:
structure literal must have at least one field (removing the 'either')
Same for below changes
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
use `::core` instead of `$crate` in `option_env!` fix rust-lang#14885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for...in.Closes #14803.
If you used a structure literal after one of these keywords, surround it
in parentheses.
[breaking-change]
r? @nick29581