Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jemalloc improvements #14119

Merged
merged 5 commits into from
May 12, 2014
Merged

jemalloc improvements #14119

merged 5 commits into from
May 12, 2014

Conversation

thestinger
Copy link
Contributor

No description provided.

alexcrichton and others added 3 commits May 11, 2014 17:41
The dist tarball doesn't depend on git, so all git submodules must be included
inside of it.
Support for this was added by 08237ca.
The `std::rt::heap` API is Rust's global allocator, so there's no need
to have this as a separate API.
///
/// These statistics may be inconsistent if other threads use the allocator during the call.
#[unstable]
pub fn stats_print() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future improvement: maybe this could take a &mut Writer; possibly with a helper function that passes &mut std::io::stderr() (or stdout)?

(This would allow it to be "logged" rather than just dumped to console.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would make sense. The je_mallctl function would also be useful as an #[unstable] unsafe function along with some safe (and possibly not forever #[unstable]) wrappers.

This requires pointing it at the valgrind headers we carry in-tree.
bors added a commit that referenced this pull request May 12, 2014
@bors bors closed this May 12, 2014
@bors bors merged commit f1735ce into rust-lang:master May 12, 2014
@thestinger thestinger deleted the heap branch May 12, 2014 02:17
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2023
internal: Remove a few allocations in hir-ty::utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants