-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jemalloc improvements #14119
jemalloc improvements #14119
Conversation
The dist tarball doesn't depend on git, so all git submodules must be included inside of it.
Support for this was added by 08237ca.
The `std::rt::heap` API is Rust's global allocator, so there's no need to have this as a separate API.
/// | ||
/// These statistics may be inconsistent if other threads use the allocator during the call. | ||
#[unstable] | ||
pub fn stats_print() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future improvement: maybe this could take a &mut Writer
; possibly with a helper function that passes &mut std::io::stderr()
(or stdout
)?
(This would allow it to be "logged" rather than just dumped to console.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that would make sense. The je_mallctl
function would also be useful as an #[unstable]
unsafe
function along with some safe (and possibly not forever #[unstable]
) wrappers.
This requires pointing it at the valgrind headers we carry in-tree.
internal: Remove a few allocations in hir-ty::utils
No description provided.