Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc alias 'then_with' for then method on bool #133789

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

rossmacarthur
Copy link
Contributor

I think its logical to search for this name since Ordering::then_with exists as well.

@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 3, 2024
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 8, 2024

📌 Commit 15feb5d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#133567 (A bunch of cleanups)
 - rust-lang#133789 (Add doc alias 'then_with' for `then` method on `bool`)
 - rust-lang#133880 (Expand home_dir docs)
 - rust-lang#134036 (crash tests: use individual mir opts instead of mir-opt-level where easily possible)
 - rust-lang#134045 (Fix some triagebot mentions paths)
 - rust-lang#134046 (Remove ignored tests for hangs w/ new solver)
 - rust-lang#134050 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 38cc868 into rust-lang:master Dec 9, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2024
Rollup merge of rust-lang#133789 - rossmacarthur:then-with-doc-alias, r=Mark-Simulacrum

Add doc alias 'then_with' for `then` method on `bool`

I think its logical to search for this name since `Ordering::then_with` exists as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants