Update tidy script, replace XXX with FIXME #13378
Conversation
| match = re.match(r'^.*//!?\s*XXX', line) | ||
| if match: | ||
| report_err("XXX is no longer necessary, use FIXME") | ||
| match = re.match(r'^.*/\*\s*XXX', line) |
There was a problem hiding this comment.
Could this and above be refactored with a binary and?
There was a problem hiding this comment.
Yes, I think it is even possible to make one regexp instead of two. I'll try to merge them.
|
Something like this. |
|
Could you squash these into one commit, otherwise this looks good to me, thanks! |
|
Done! |
|
It looks like a rebase went a little awry (seems to have picked up an extra commit), perhaps a |
|
Yeah, something goes wrong. How can I revert it back? Rebase it again? |
|
If you rebase on to a recent master it will likely go away ( |
Few places where previous version of tidy script cannot find XXX: * inside one-line comment preceding by a few spaces; * inside multiline comments (now it finds it if multiline comment starts on the same line with XXX). Change occurences of XXX found by new tidy script.
|
I think it is fixed now. I probably squashed first one more commit than I need. Thanks to o11c I found a way to fix it with |
No description provided.