Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo README.md #133744

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix typo README.md #133744

merged 1 commit into from
Dec 2, 2024

Conversation

HypheX
Copy link
Contributor

@HypheX HypheX commented Dec 2, 2024

Fix typo README.md 2: Electric Boogaloo
Expands on #131144

@rustbot
Copy link
Collaborator

rustbot commented Dec 2, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @fmease (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 2, 2024
@fmease fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2024
@fmease
Copy link
Member

fmease commented Dec 2, 2024

Please follow: https://rustc-dev-guide.rust-lang.org/git.html#git-is-trying-to-rebase-commits-i-didnt-write

@fmease fmease marked this pull request as draft December 2, 2024 10:24
@HypheX
Copy link
Contributor Author

HypheX commented Dec 2, 2024

Yeah, apologies, I'm working on it.

@HypheX
Copy link
Contributor Author

HypheX commented Dec 2, 2024

There we go, fixed.

@jieyouxu jieyouxu removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-rustdoc-json Area: Rustdoc JSON backend labels Dec 2, 2024
@fmease fmease marked this pull request as ready for review December 2, 2024 11:38
@fmease
Copy link
Member

fmease commented Dec 2, 2024

I don't know if tests/ui/README.md still pulls its weight contrary to the corresponding chapter(s) in the rustc dev guide but well, doesn't matter right now.

Thanks @bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 2, 2024

📌 Commit c8e0724 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 2, 2024
@fmease fmease mentioned this pull request Dec 2, 2024
Closed
@HypheX HypheX closed this Dec 2, 2024
@HypheX HypheX deleted the typo-fix branch December 2, 2024 12:33
@HypheX HypheX restored the typo-fix branch December 2, 2024 12:35
@fmease
Copy link
Member

fmease commented Dec 2, 2024

Any particular reason you closed this PR? It was in the queue and would've been merged just fine.

@HypheX HypheX deleted the typo-fix branch December 2, 2024 12:37
@fmease
Copy link
Member

fmease commented Dec 2, 2024

I can reopen and reapprove if you're fine with that -- only if you consent though of course.

@HypheX HypheX restored the typo-fix branch December 2, 2024 12:43
@HypheX
Copy link
Contributor Author

HypheX commented Dec 2, 2024 •
edited
Loading

I was doing some cleanup of useless branches on my end as I'm doing work on a few other PRs, and accidentally axed the branch on my fork... twice. I restored the branch again. Sorry for the annoyance. 😅

@fmease fmease reopened this Dec 2, 2024
@fmease
Copy link
Member

fmease commented Dec 2, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Dec 2, 2024

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Dec 2, 2024

📌 Commit c8e0724 has been approved by fmease

It is now in the queue for this repository.

@fmease
Copy link
Member

fmease commented Dec 2, 2024

No worries!

@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 2, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2024
@bors
Auto merge of rust-lang#133760 - GuillaumeGomez:rollup-2c1y8c3, r=Gui…
d49be02 
…llaumeGomez

Rollup of 13 pull requests

Successful merges:

 - rust-lang#133603 (Eliminate magic numbers from expression precedence)
 - rust-lang#133715 (rustdoc-json: Include safety of `static`s)
 - rust-lang#133721 (rustdoc-json: Add test for `impl Trait for dyn Trait`)
 - rust-lang#133725 (Remove `//@ compare-output-lines-by-subset`)
 - rust-lang#133730 (Add pretty-printer parenthesis insertion test)
 - rust-lang#133736 (Add `needs-target-has-atomic` directive)
 - rust-lang#133739 (Re-add myself to rotation)
 - rust-lang#133743 (Fix docs for `<[T]>::as_array`.)
 - rust-lang#133744 (Fix typo README.md)
 - rust-lang#133745 (Remove static HashSet for default IDs list)
 - rust-lang#133749 (mir validator: don't store mir phase)
 - rust-lang#133751 (remove `Ty::is_copy_modulo_regions`)
 - rust-lang#133757 (`impl Default for EarlyDiagCtxt`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ed08803 into rust-lang:master Dec 2, 2024
12 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 2, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2024
@rust-timer
Unrolled build for rust-lang#133744
be18b6e 
Rollup merge of rust-lang#133744 - HypheX:typo-fix, r=fmease

Fix typo README.md

Fix typo README.md 2: Electric Boogaloo
Expands on rust-lang#131144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
5 participants
@HypheX @rustbot @fmease @bors @jieyouxu