Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos by changing happend to happened #133689

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

HomelikeBrick42
Copy link
Contributor

I just noticed this typo before and decided to fix it :3

@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jieyouxu (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 30, 2024
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

jieyouxu commented Dec 1, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 1, 2024

📌 Commit 4cb1582 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#128184 (std: refactor `pthread`-based synchronization)
 - rust-lang#132047 (Robustify and genericize return-type-notation resolution in `resolve_bound_vars`)
 - rust-lang#133515 (fix: hurd build, stat64.st_fsid was renamed to st_dev)
 - rust-lang#133602 (fix: fix codeblocks in `PathBuf` example)
 - rust-lang#133622 (update link to "C++ Exceptions under the hood" blog)
 - rust-lang#133660 (Do not create trait object type if missing associated types)
 - rust-lang#133686 (Add diagnostic item for `std::ops::ControlFlow`)
 - rust-lang#133689 (Fixed typos by changing `happend` to `happened`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c0fa0ec into rust-lang:master Dec 1, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2024
Rollup merge of rust-lang#133689 - HomelikeBrick42:master, r=jieyouxu

Fixed typos by changing `happend` to `happened`

I just noticed this typo before and decided to fix it :3
@rustbot rustbot added this to the 1.85.0 milestone Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants