def_collector: rework trivial const-arg handling #133455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
lcnr
force-pushed
the
uwu2
branch
4 times, most recently
from
613056b to
5f05a18
Compare
see the comment on `handle_lazy_anon_const_def`
lcnr
force-pushed
the
uwu2
branch
2 times, most recently
from
51a3ab0 to
2c0df64
Compare
lcnr
commented
Nov 25, 2024
| // See `DefCollector::handle_lazy_anon_const_def` for more details. | ||
| // | ||
| // FIXME(lcnr): I believe that this shouldn't cause any issues wrt to | ||
| // incremental compilation, but am not 100% confident. | ||
| let parent_def = self.cx.resolver.invocation_parent(expn_id); |
There was a problem hiding this comment.
an existing concern. would accept this as is for now and handle it in case it is problematic
I looked a bit into ways to make this more resilient but gave up on that for now. If there's any affected code which is not covered by the existing tests, I'll look into this at that point.
|
i've looked into an alternative approach for a bit which changes |
This comment has been minimized.
This comment has been minimized.
|
closing in favor of #133468 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 28, 2024
always create `DefId`s for anon consts but don't use them anywhere, we intentionally don't encode them in the crate metadata. best reviewed by disabling whitespace. This pretty much reimplements rust-lang#133285 while adding the tests of rust-lang#133455. Fixes rust-lang#133064 r? `@BoxyUwU` `@compiler-errors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see the comment on
handle_lazy_anon_const_defr? @compiler-errors @BoxyUwU