Add simd_relaxed_fma intrinsic #133395
Add simd_relaxed_fma intrinsic #133395
Conversation
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred to the platform-builtins intrinsics. Make sure the cc @antoyo, @GuillaumeGomez, @bjorn3, @calebzulawski, @programmerjake Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @rust-lang/wg-const-eval Some changes occurred in compiler/rustc_codegen_gcc |
calebzulawski
force-pushed
the
simd_relaxed_fma
branch
from
552ed67
to
e73e9f9
Compare
| /// `T` must be a vector of floats. | ||
| #[cfg(not(bootstrap))] | ||
| #[rustc_nounwind] | ||
| pub fn simd_relaxed_fma<T>(x: T, y: T, z: T) -> T; |
There was a problem hiding this comment.
So this is like fmuladd on scalars? That should be mentioned, and probably it makes sense to copy the doc comment from there.
There was a problem hiding this comment.
Ah I didn't realize there was a scalar version... is it used anywhere?
There was a problem hiding this comment.
to match the scalar version, imo it should be renamed to simd_fmuladd, also to avoid confusion with any fast-math semantics
There was a problem hiding this comment.
It's not used yet, it was added in preparation for exposing corresponding methods on the float types.
There was a problem hiding this comment.
to match the scalar version, imo it should be renamed to simd_fmuladd, also to avoid confusion with any fast-math semantics
That's a pretty bad name though IMO, it is used for the scalar version only because that's how LLVM calls them.
I like relaxed_fma. I don't think it is confusing with fast-math semantics, we don't call those "relaxed" after all.
There was a problem hiding this comment.
hmm, maybe...though I want to say I've seen relaxed suggested for fast math functions...
There was a problem hiding this comment.
though, since it isn't always fused, I think simd_something_mul_add is better than simd_something_fma
There was a problem hiding this comment.
simd_mul_add? simd_relaxed_mul_add?
There was a problem hiding this comment.
yeah, either of those would be ok-ish -- simd_mul_add makes one think of f32::mul_add which is always fused (imo naming f32::mul_add mul_add is a mistake, but there's nothing we can do now...).
No, we already implement |
Adds compiler support for rust-lang/portable-simd#387 (comment)
r? @workingjubilee
cc @RalfJung is this kind of nondeterminism a problem for miri/opsem?