Bail on more errors in dyn ty lowering #133394
Open
+61
−455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
HIR ty lowering was modified cc @fmease |
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
dyn-more-errors
branch
from
ce5c754
to
3ba3b74
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
dyn-more-errors
branch
from
3ba3b74
to
cfa8fcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have more than one principal trait, or if we have a principal trait with errors in it, then bail with
TyKind::Errorrather than attempting lowering. Lowering a dyn trait with more than one principal just arbitrarily chooses the first one and drops the subsequent ones, and lowering a dyn trait path with errors in it is just kinda useless.This suppresses unnecessary errors which I think is net-good, but also is important to make sure that we don't end up leaking
{type error}in #133388 error messaging :)r? types