remove is_trivially_const_drop #133371
remove is_trivially_const_drop #133371
Conversation
rustbot
added
S-waiting-on-review
|
Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval |
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
…<try> remove is_trivially_const_drop I'm not sure this still brings any perf benefits, so let's benchmark this. r? `@compiler-errors`
|
if perf is neutral then r=me |
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
is_trivially_const_drop
branch
from
5645d66
to
bd00de7
Compare
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
@bors try |
|
⌛ Trying commit bd00de7 with merge 5f8e7058d31eaf1c73bf220322209f5bec6532b1... |
…<try> remove is_trivially_const_drop I'm not sure this still brings any perf benefits, so let's benchmark this. r? `@compiler-errors`
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (5f8e705): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 0.6%, secondary 1.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -2.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 795.253s -> 796.142s (0.11%) |
rustbot
removed
the
S-waiting-on-perf
|
@bors r=compiler-errors
|
bors
added
S-waiting-on-bors
|
@bors rollup |
…r=compiler-errors remove is_trivially_const_drop I'm not sure this still brings any perf benefits, so let's benchmark this. r? `@compiler-errors`
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#133300 (inject_panic_runtime(): Avoid double negation for 'any non rlib') - rust-lang#133301 (Add code example for `wrapping_neg` method for signed integers) - rust-lang#133371 (remove is_trivially_const_drop) - rust-lang#133389 (Stabilize `const_float_methods`) - rust-lang#133398 (rustdoc: do not call to_string, it's already impl Display) - rust-lang#133405 (tidy: Distinguish between two different meanings of "style file") r? `@ghost` `@rustbot` modify labels: rollup
I'm not sure this still brings any perf benefits, so let's benchmark this.
r? @compiler-errors