-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow injecting a profiler runtime into #![no_core]
crates
#133369
base: master
Are you sure you want to change the base?
Conversation
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
I can't say I'm too familiar with |
This crate doesn't contain any actual Rust code; it's just C/C++ code built and packaged in a Rust-friendly way.
89e2ad0
to
bd7aa4b
Compare
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
r? compiler It's possible to write a run-make test that actually runs cargo with |
r? jieyouxu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this seems reasonable to me, just one nit. You can r=me with the nit.
@rustbot author |
@bors rollup=never (profiler runtime setup modifications) |
Now that the profiler runtime is itself `#![no_core]`, it can be a dependency of other no_core crates, including core.
bd7aa4b
to
6798eca
Compare
An alternative to #133300, allowing
-Cinstrument-coverage
to be used with-Zbuild-std
.The incompatibility between
profiler_builtins
and#![no_core]
crates appears to have been caused by profiler_builtins depending on core, and therefore conflicting with core (or minicore).But that's a false dependency, because the profiler doesn't contain any actual Rust code. So we can just mark the profiler itself as
#![no_core]
, and remove the incompatibility error.For context, the error was originally added by #79958.