Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #133161

Closed
wants to merge 16 commits into from

Commits on Nov 13, 2024

  1. Configuration menu
    Copy the full SHA
    acb9da7 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Merge pull request rust-lang#18495 from tareknaser/syntax_factory_reo…

    …rder_fields
    
    Migrate `reorder_fields` Assist to Use `SyntaxFactory`
    davidbarsky authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5e31398 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. Bump xshell

    lnicola committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    9f4f903 View commit details
    Browse the repository at this point in the history
  2. Merge pull request rust-lang#18518 from lnicola/bump-xshell

    minor: Bump xshell
    lnicola authored Nov 16, 2024
    Configuration menu
    Copy the full SHA
    cc4ffa7 View commit details
    Browse the repository at this point in the history
  3. Fix related documents diagnostics

    They were converted to LSP position using the current file's line index, which is obviously wrong.
    ChayimFriedman2 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    744e8e8 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. Merge pull request rust-lang#18519 from ChayimFriedman2/invalid-offset

    fix: Fix related documents diagnostics
    lnicola authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    647749a View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Configuration menu
    Copy the full SHA
    8b43a7e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d6b228 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2902bca View commit details
    Browse the repository at this point in the history
  4. Move -l option parsing into its own submodule

    No functional change (yet).
    Zalathar committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    478db48 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    78edefe View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9d4b1b2 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#132934 - Zalathar:native-libs, r=jieyouxu

    Overhaul the `-l` option parser (for linking to native libs)
    
    The current parser for `-l` options has accumulated over time, making it hard to follow. This PR tries to clean it up in several ways.
    
    Key changes:
    - This code now gets its own submodule, to slightly reduce clutter in `rustc_session::config`.
    - Cleaner division between iterating over multiple `-l` options, and processing each individual one.
    - Separate “split” step that breaks up the value string into `[KIND[:MODIFIERS]=]NAME[:NEW_NAME]`, but leaves parsing/validating those parts to later steps.
      - This step also gets its own (disposable) unit test, to make sure it works as expected.
    - A context struct reduces the burden of parameter passing, and makes it easier to write error messages that adapt to nightly/stable compilers.
    - Fewer calls to `nightly_options` helper functions, because at this point we can get the same information from `UnstableOptions` and `UnstableFeatures` (which are downstream of earlier calls to those helper functions).
    
    There should be no overall change in compiler behaviour.
    matthiaskrgr authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    e578503 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#133142 - RalfJung:naming-is-hard, r=compile…

    …r-errors
    
    rename rustc_const_stable_intrinsic -> rustc_intrinsic_const_stable_indirect
    
    In rust-lang#120370 this name caused confusion as the author thought the intrinsic was stable. So let's try a different name...
    
    If we can land this before the beta cutoff we can avoid needing `cfg(bootstrap)` for this. ;)
    Cc ``@compiler-errors`` ``@saethlin``
    matthiaskrgr authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    8531299 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#133145 - kornelski:static-mutex, r=traviscross

    Document alternatives to `static mut`
    
    In rust-lang#133143 I've noticed alternatives to `static mut` aren't documented anywhere.
    matthiaskrgr authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d6afa09 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#133158 - lnicola:sync-from-ra, r=lnicola

    Subtree update of `rust-analyzer`
    
    r? ``@ghost``
    matthiaskrgr authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    759941a View commit details
    Browse the repository at this point in the history