Stabilize noop_waker

[eholk]

Tracking Issue: #98286

This is a handy feature that's been used widely in tests and example async code and it'd be nice to make it available to users.

cc @rust-lang/wg-async

[rustbot]

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[yoshuawuyts]

Stabilizing this seems reasonable to me! We spent an extended period discussing this in @rust-lang/wg-async triage earlier this year, and I believe we were generally in favor of moving forward with this API. Thank you for putting this up!

[Amanieu]

@rfcbot fcp merge

[rfcbot]

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Amanieu
• @BurntSushi
• @dtolnay
• @joshtriplett
• @m-ou-se

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[rustbot]

Some changes occurred in tests/ui/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in coverage tests.

cc @Zalathar

[bors]

☔ The latest upstream changes (presumably #133349) made this pull request unmergeable. Please resolve the merge conflicts.

[matthiaskrgr]

@bors r-
#133783 (comment)

[eholk]

@bors r=dtolnay rollup=never

I somehow managed not to include the change to await_ready.rs that removed the noop_waker feature and only included the change to the .coverage file. This is fixed now.

[bors]

📌 Commit 279d3d2 has been approved by dtolnay

It is now in the queue for this repository.

[bors]

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

1. git checkout stabilize-noop-waker (switch to your branch)
2. git fetch upstream master (retrieve the latest master)
3. git rebase upstream/master -p (rebase on top of it)
4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
5. git push self stabilize-noop-waker --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

Auto-merging tests/ui/async-await/async-closures/mangle.rs
Auto-merging tests/ui/async-await/async-closures/inline-body.rs
Auto-merging tests/crashes/124020.rs
CONFLICT (content): Merge conflict in tests/crashes/124020.rs
Auto-merging src/tools/miri/tests/pass/async-closure-drop.rs
CONFLICT (content): Merge conflict in src/tools/miri/tests/pass/async-closure-drop.rs
Auto-merging src/tools/miri/tests/pass/async-closure-captures.rs
CONFLICT (content): Merge conflict in src/tools/miri/tests/pass/async-closure-captures.rs
Auto-merging library/core/tests/lib.rs
Automatic merge failed; fix conflicts and then commit the result.

[eholk]

@bors r=dtolnay

Rebased after conflicting upstream changes.

[bors]

📌 Commit 31689e9 has been approved by dtolnay

It is now in the queue for this repository.

[Zalathar]

Be aware that #133849 is going to churn all of the coverage-test snapshot files, so if that lands you'll need another rebase and bless to fix the conflicts. But the test .rs files aren't modified, so you shouldn't need to resolve anything manually.

Also, it looks like this PR is not actually in the bors queue for some reason, despite being approved.

[oli-obk]

@bors r-
@bors r=dtolnay

[bors]

📌 Commit 279d3d2 has been approved by dtolnay

It is now in the queue for this repository.

[bors]

☔ The latest upstream changes (presumably #133865) made this pull request unmergeable. Please resolve the merge conflicts.