Proper support for cross-crate recursive const stability checks #132541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
RalfJung
commented
Nov 2, 2024
| // `#[rustc_const_stable_indirect]` also requires a const fn | ||
| #[rustc_const_stable_indirect] | ||
| #[unstable(feature = "unstable", issue = "none")] | ||
| pub fn not_a_const_fn() {} |
There was a problem hiding this comment.
This regresses complaining about rustc_const_stable_indirect on non-const-fn... but keeping that error would make the code even more messy, and we also don't error for rustc_promotable on non-const-fn, so 🤷
There's an ongoing effort to redo the way we do attributes, that should hopefully make this easier in the future.
RalfJung
commented
Nov 2, 2024
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
const-stable-extern-crate
branch
from
51004b7
to
8a6fd66
Compare
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
|
That's a tricky one... when one force-unstable-if-unmarked crate calls things from another one, how does that work? The callee crate has everything under the |
RalfJung
force-pushed
the
const-stable-extern-crate
branch
from
8a6fd66
to
96f9ada
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
const-stable-extern-crate
branch
from
8bf4b22
to
dbf3fba
Compare
3 tasks
|
☔ The latest upstream changes (presumably #132479) made this pull request unmergeable. Please resolve the merge conflicts. |
RalfJung
force-pushed
the
const-stable-extern-crate
branch
from
dbf3fba
to
a307b47
Compare
|
☔ The latest upstream changes (presumably #132586) made this pull request unmergeable. Please resolve the merge conflicts. |
RalfJung
force-pushed
the
const-stable-extern-crate
branch
from
a307b47
to
28e920a
Compare
|
☔ The latest upstream changes (presumably #132603) made this pull request unmergeable. Please resolve the merge conflicts. |
RalfJung
force-pushed
the
const-stable-extern-crate
branch
from
28e920a
to
c98d23d
Compare
|
The base PR landed, so this is ready to go now. :) |
RalfJung
force-pushed
the
const-stable-extern-crate
branch
from
c98d23d
to
6632ba1
Compare
|
Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval |
…e-unstable-if-unmarked
|
☔ The latest upstream changes (presumably #132831) made this pull request unmergeable. Please resolve the merge conflicts. |
RalfJung
force-pushed
the
const-stable-extern-crate
branch
from
6632ba1
to
430a398
Compare
compiler-errors
approved these changes
Nov 11, 2024
| @@ -53,10 +53,11 @@ impl<'mir, 'tcx> ConstCx<'mir, 'tcx> { | |||
| } | |||
|
|
|||
| pub fn enforce_recursive_const_stability(&self) -> bool { | |||
| // We can skip this if `staged_api` is not enabled, since in such crates | |||
| // `lookup_const_stability` will always be `None`. | |||
| // We can skip this if neither `staged_api` nor `-Zforrce-unstable-if-unmarked` are enabled, | |||
|
r=me after really tiny nit |
RalfJung
force-pushed
the
const-stable-extern-crate
branch
from
430a398
to
3780496
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
3 tasks
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 12, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#131831 (extend the "if-unchanged" logic for compiler builds) - rust-lang#132541 (Proper support for cross-crate recursive const stability checks) - rust-lang#132657 (AIX: add run-make support) - rust-lang#132901 (Warn about invalid `mir-enable-passes` pass names) - rust-lang#132923 (Triagebot: Consolidate the T-compiler ad hoc assignment groups) - rust-lang#132938 (Make precise capturing suggestion machine-applicable only if it has no APITs) - rust-lang#132947 (clarify `must_produce_diag` ICE for debugging) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 12, 2024
Rollup merge of rust-lang#132541 - RalfJung:const-stable-extern-crate, r=compiler-errors Proper support for cross-crate recursive const stability checks ~~Stacked on top of rust-lang#132492; only the last three commits are new.~~ In a crate without `staged_api` but with `-Zforce-unstable-if-unmarked`, we now subject all functions marked with `#[rustc_const_stable_indirect]` to recursive const stability checks. We require an opt-in so that by default, a crate can be built with `-Zforce-unstable-if-unmarked` and use nightly features as usual. This property is recorded in the crate metadata so when a `staged_api` crate calls such a function, it sees the `#[rustc_const_stable_indirect]` and allows it to be exposed on stable. This, finally, will let us expose `const fn` from hashbrown on stable. The second commit makes const stability more like regular stability: via `check_missing_const_stability`, we ensure that all publicly reachable functions have a const stability attribute -- both in `staged_api` crates and `-Zforce-unstable-if-unmarked` crates. To achieve this, we move around the stability computation so that const stability is computed after regular stability is done. This lets us access the final result of the regular stability computation, which we use so that `const fn` can inherit the regular stability (but only if that is "unstable"). Fortunately, this lets us get rid of an `Option` in `ConstStability`. This is the last PR that I have planned in this series. r? `@compiler-errors`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 14, 2024
…, r=compiler-errors Proper support for cross-crate recursive const stability checks ~~Stacked on top of rust-lang#132492; only the last three commits are new.~~ In a crate without `staged_api` but with `-Zforce-unstable-if-unmarked`, we now subject all functions marked with `#[rustc_const_stable_indirect]` to recursive const stability checks. We require an opt-in so that by default, a crate can be built with `-Zforce-unstable-if-unmarked` and use nightly features as usual. This property is recorded in the crate metadata so when a `staged_api` crate calls such a function, it sees the `#[rustc_const_stable_indirect]` and allows it to be exposed on stable. This, finally, will let us expose `const fn` from hashbrown on stable. The second commit makes const stability more like regular stability: via `check_missing_const_stability`, we ensure that all publicly reachable functions have a const stability attribute -- both in `staged_api` crates and `-Zforce-unstable-if-unmarked` crates. To achieve this, we move around the stability computation so that const stability is computed after regular stability is done. This lets us access the final result of the regular stability computation, which we use so that `const fn` can inherit the regular stability (but only if that is "unstable"). Fortunately, this lets us get rid of an `Option` in `ConstStability`. This is the last PR that I have planned in this series. r? `@compiler-errors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #132492; only the last three commits are new.In a crate without
staged_apibut with-Zforce-unstable-if-unmarked, we now subject all functions marked with#[rustc_const_stable_indirect]to recursive const stability checks. We require an opt-in so that by default, a crate can be built with-Zforce-unstable-if-unmarkedand use nightly features as usual. This property is recorded in the crate metadata so when astaged_apicrate calls such a function, it sees the#[rustc_const_stable_indirect]and allows it to be exposed on stable. This, finally, will let us exposeconst fnfrom hashbrown on stable.The second commit makes const stability more like regular stability: via
check_missing_const_stability, we ensure that all publicly reachable functions have a const stability attribute -- both instaged_apicrates and-Zforce-unstable-if-unmarkedcrates. To achieve this, we move around the stability computation so that const stability is computed after regular stability is done. This lets us access the final result of the regular stability computation, which we use so thatconst fncan inherit the regular stability (but only if that is "unstable"). Fortunately, this lets us get rid of anOptioninConstStability.This is the last PR that I have planned in this series.
r? @compiler-errors