Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 3 pull requests #131963

Closed
wants to merge 6 commits into from

Commits on Oct 19, 2024

  1. Configuration menu
    Copy the full SHA
    28fce83 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. Configuration menu
    Copy the full SHA
    3310419 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e32a5be View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#131926 - clubby789:configure-enable, r=Kobzol

    Align boolean option descriptions in `configure.py`
    
    Boolean options are currently printed as
    ```
    Options
            --enable-debug  OR  --disable-debug enables debugging environment; does not affect optimization of bootstrapped code
            --enable-docs  OR  --disable-docs build standard library documentation
            --enable-compiler-docs  OR  --disable-compiler-docs build compiler documentation
            --enable-optimize-tests  OR  --disable-optimize-tests build tests with optimizations
            --enable-verbose-tests  OR  --disable-verbose-tests enable verbose output when running tests
            --enable-ccache  OR  --disable-ccache invoke gcc/clang via ccache to reuse object files between builds
            --enable-sccache  OR  --disable-sccache invoke gcc/clang via sccache to reuse object files between builds
            --enable-local-rust  OR  --disable-local-rust use an installed rustc rather than downloading a snapshot
            --local-rust-root=VAL          set prefix for local rust binary
            --enable-local-rebuild  OR  --disable-local-rebuild assume local-rust matches the current version, for rebuilds; implies local-rust, and is implied if local-rust already matches the current version
    ```
    as of rust-lang#131117
    
    imo, this is a little difficult to skim. This PR changes this to align the `OR`s and push the description onto a newline:
    
    ```
    Options
            --enable-debug                     OR --disable-debug
                    enables debugging environment; does not affect optimization of bootstrapped code
            --enable-docs                      OR --disable-docs
                    build standard library documentation
            --enable-compiler-docs             OR --disable-compiler-docs
                    build compiler documentation
            --enable-optimize-tests            OR --disable-optimize-tests
                    build tests with optimizations
            --enable-verbose-tests             OR --disable-verbose-tests
                    enable verbose output when running tests
            --enable-ccache                    OR --disable-ccache
                    invoke gcc/clang via ccache to reuse object files between builds
            --enable-sccache                   OR --disable-sccache
                    invoke gcc/clang via sccache to reuse object files between builds
            --enable-local-rust                OR --disable-local-rust
                    use an installed rustc rather than downloading a snapshot
            --local-rust-root=VAL          set prefix for local rust binary
            --enable-local-rebuild             OR --disable-local-rebuild
                    assume local-rust matches the current version, for rebuilds; implies local-rust, and is implied if local-rust already matches the current version
        ```
    matthiaskrgr authored Oct 20, 2024
    Configuration menu
    Copy the full SHA
    4aaa2ea View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#131961 - jieyouxu:dirty, r=Zalathar

    compiletest: tidy up how `tidy` and `tidy` (html version) are disambiguated
    
    Rename `has_tidy` -> `has_html_tidy` (`tidy` is also a bootstrap tool, but rustdoc uses a html tidy that has the same binary name). Follow-up to rust-lang#131941.
    
    Also apparently `runtest.rs` is short enough now, we can delete the `tidy` (bootstrap version) ignore for file length.
    matthiaskrgr authored Oct 20, 2024
    Configuration menu
    Copy the full SHA
    2515d15 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#131962 - Zalathar:llvm-set-section, r=Swati…

    …nem,workingjubilee
    
    Make `llvm::set_section` take a `&CStr`
    
    There's no reason to convert the section name to an intermediate `String`, when the LLVM-C API wants a C string anyway.
    
    Follow-up to rust-lang#131876.
    matthiaskrgr authored Oct 20, 2024
    Configuration menu
    Copy the full SHA
    29f9964 View commit details
    Browse the repository at this point in the history