Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the test cfg a userspace check-cfg #131729

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make the test cfg a userspace check-cfg #131729

wants to merge 2 commits into from
+71 −64

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Oct 15, 2024 •
edited
Loading

This PR implements MCP rust-lang/compiler-team#785, which makes the test cfg a "userspace" check-cfg, i.e. no longer included in the well known cfg list.

Things to do:

  • Accept the MCP
  • Mark test in Cargo

@rustbot labels +S-waiting-on-MCP +F-check_cfg
r? @petrochenkov

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 15, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2024

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@Urgau Urgau added F-check-cfg --check-cfg S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. labels Oct 15, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov petrochenkov mentioned this pull request Oct 19, 2024
Open
3 tasks
@petrochenkov
Copy link
Contributor

Blocked on the FCP in rust-lang/compiler-team#785.
@rustbot blocked

@rustbot rustbot added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2024
@bors

This comment was marked as resolved.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan left review comments

Assignees

@petrochenkov petrochenkov

Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc F-check-cfg --check-cfg S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
compiletest maintenance and improvements
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Urgau @rustbot @rust-log-analyzer @petrochenkov @bors @onur-ozkan