[rustdoc] Change impl items indent #131718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
impl-items-indent
branch
from
3a03f86
to
8dae3bd
Compare
|
Fixed tidy issue. |
This comment has been minimized.
This comment has been minimized.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
notriddle
added
T-rustdoc-frontend
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
@rfcbot poll User visible ui change |
|
Team member @notriddle has asked teams: T-rustdoc-frontend, for consensus on:
|
|
☔ The latest upstream changes (presumably #132099) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
impl-items-indent
branch
from
8dae3bd
to
7aadaf0
Compare
|
Fixed merge conflict and fixed GUI test. |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
impl-items-indent
branch
from
7aadaf0
to
4f20626
Compare
|
Note for future self: run ALL tests after making changes. CI passed! \o/ |
|
Looks good, except that there's still a tiny bit of indent that makes it look weird IMO:
We should have the text aligned with the |
|
Good point! Gonna change that. |
|
Applied suggestion. Updated the image and the demo. |
Thanks, LGTM. |
|
Time to r+ then, thanks everyone! @bors r=rustdoc rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 29, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#131323 (Support `clobber_abi` in AVR inline assembly) - rust-lang#131718 ([rustdoc] Change impl items indent) - rust-lang#133565 (chore: fix 404 status URL) - rust-lang#133575 (Fix typo in RELEASES.md) - rust-lang#133577 (Document s390x machine access via community cloud) - rust-lang#133584 (Update more 2024 tests to remove -Zunstable-options) - rust-lang#133592 (Misc: better instructions for envrc, ignore `/build` instead of `build/`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 29, 2024
Rollup merge of rust-lang#131718 - GuillaumeGomez:impl-items-indent, r=rustdoc [rustdoc] Change impl items indent Fixes rust-lang#131704. | before | after | |-|-| |  |  | Can be tested [here](https://rustdoc.crud.net/imperio/impl-items-indent/bar/struct.Bar.html). r? `@notriddle`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131704.
Can be tested here.
r? @notriddle