E0793: Clarify that it applies to unions as well #131472
Open
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Adjust the language slightly to be more consistent with other similar messages (`was created` instead of `got created`). - Add a short section on `union` - Add an example line showing referencing a field in a packed struct is safe if the field's type isn't more strictly aligned than the pack.
rustbot
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #131458) made this pull request unmergeable. Please resolve the merge conflicts. |
| let foo = Foo { field1: 0 }; | ||
| // Accessing the field directly is fine. | ||
| let val = foo.field1; | ||
| // A reference to a packed union field causes a error. |
There was a problem hiding this comment.
Suggested change
| // A reference to a packed union field causes a error. | |
| // A reference to a packed union field causes an error. |
Comment on lines
+74
to
+77
| // Accessing the field directly is fine. | ||
| let val = foo.field1; | ||
| // A reference to a packed union field causes a error. | ||
| let val = &foo.field1; // ERROR |
There was a problem hiding this comment.
Suggested change
| // Accessing the field directly is fine. | |
| let val = foo.field1; | |
| // A reference to a packed union field causes a error. | |
| let val = &foo.field1; // ERROR | |
| // Accessing the field directly is fine. | |
| let val = foo.field1; | |
| // A reference to a packed union field causes a error. | |
| let val = &foo.field1; // ERROR |
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
ping from triage - can you post your status on this PR and address the comments from the reviewer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
was createdinstead ofgot created).union.This might need to wait for #131456 to merge first? Not sure.
r? compiler-errors