-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] compiler: dont try to compile impossible alignment on 16-bit #131276
Closed
workingjubilee
wants to merge
1
commit into
rust-lang:master
from
workingjubilee:dispel-evil-16-bit-alignment
Closed
[WIP] compiler: dont try to compile impossible alignment on 16-bit #131276
workingjubilee
wants to merge
1
commit into
rust-lang:master
from
workingjubilee:dispel-evil-16-bit-alignment
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Oct 5, 2024
The job Click to see the possible cause of the failure (guessed by this bot)
|
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Oct 28, 2024
…ieyouxu error on alignments greater than `isize::MAX` Fixes rust-lang#131122 On zulip someone had a concern that it was legal to create a type with alignment `isize::MAX + 1`, but I do not believe this should be allowed for `repr(align)`, as `repr(align)` also increases the *size* of the type, and that would be larger than the maximum allowed size of objects. (cc `@workingjubilee` rust-lang#131276)
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 28, 2024
Rollup merge of rust-lang#131633 - asquared31415:align_isize_max, r=jieyouxu error on alignments greater than `isize::MAX` Fixes rust-lang#131122 On zulip someone had a concern that it was legal to create a type with alignment `isize::MAX + 1`, but I do not believe this should be allowed for `repr(align)`, as `repr(align)` also increases the *size* of the type, and that would be larger than the maximum allowed size of objects. (cc `@workingjubilee` rust-lang#131276)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was originally intended to solve #131122 but I'm not very happy with the lack of a span. Forgot about it and then remembered it was sitting around. Mostly posting this so @asquared31415 can cannibalize it if desired in the process of coming up with a better solution maybe.
r? @ghost