Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: Rename "object safe" to "dyn compatible" #130826

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

fmease
Copy link
Member

@fmease fmease commented Sep 25, 2024

Completed T-lang FCP: rust-lang/lang-team#286 (comment).
Tracking issue: #130852

Excludes compiler/rustc_codegen_cranelift (to be filed separately).
Includes Stable MIR.

Regarding relnotes Marks issues that should be documented in the release notes of the next release. , I guess I will manually open a relnotes-tracking-issue Marks issues tracking what text to put in release notes. since this change affects everything (compiler, library, tools, docs, books, everyday language).

r? ghost

@fmease fmease added the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Sep 25, 2024
@rustbot rustbot added PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Sep 25, 2024
@fmease fmease added the rla-silenced Silences rust-log-analyzer postings to the PR it's added on. label Sep 25, 2024
@fmease fmease force-pushed the compiler-mv-obj-safe-dyn-compat branch from 236e368 to f874dfd Compare September 25, 2024 11:26
@fmease fmease force-pushed the compiler-mv-obj-safe-dyn-compat branch from f874dfd to 01a063f Compare September 25, 2024 11:27
@fmease fmease removed the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Sep 27, 2024
@fmease fmease changed the title [pending] Compiler: Rename "object safe" to "dyn compatible" Compiler: Rename "object safe" to "dyn compatible" Sep 27, 2024
@fmease fmease marked this pull request as ready for review September 27, 2024 17:42
@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2024

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

changes to the core type system

cc @compiler-errors, @lcnr

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in compiler/rustc_sanitizers

cc @rust-lang/project-exploit-mitigations, @rcvalle

@fmease
Copy link
Member Author

fmease commented Sep 27, 2024

r? compiler

@compiler-errors
Copy link
Member

LGTM. I reviewed this mostly by reverting the major rename changes and then reviewing the remainder of the diff.

@bors r+

@bors
Copy link
Contributor

bors commented Sep 27, 2024

📌 Commit 01a063f has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130718 (Cleanup some known-bug issues)
 - rust-lang#130730 (Reorganize Test Headers)
 - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
 - rust-lang#130915 (fix typo in triagebot.toml)
 - rust-lang#130926 (Update cc to 1.1.22 in library/)
 - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130718 (Cleanup some known-bug issues)
 - rust-lang#130730 (Reorganize Test Headers)
 - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
 - rust-lang#130915 (fix typo in triagebot.toml)
 - rust-lang#130926 (Update cc to 1.1.22 in library/)
 - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130718 (Cleanup some known-bug issues)
 - rust-lang#130730 (Reorganize Test Headers)
 - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
 - rust-lang#130915 (fix typo in triagebot.toml)
 - rust-lang#130926 (Update cc to 1.1.22 in library/)
 - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a935064 into rust-lang:master Sep 28, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 28, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 28, 2024
Rollup merge of rust-lang#130826 - fmease:compiler-mv-obj-safe-dyn-compat, r=compiler-errors

Compiler: Rename "object safe" to "dyn compatible"

Completed T-lang FCP: rust-lang/lang-team#286 (comment).
Tracking issue: rust-lang#130852

Excludes `compiler/rustc_codegen_cranelift` (to be filed separately).
Includes Stable MIR.

Regarding https://github.com/rust-lang/rust/labels/relnotes, I guess I will manually open a https://github.com/rust-lang/rust/labels/relnotes-tracking-issue since this change affects everything (compiler, library, tools, docs, books, everyday language).

r? ghost
@fmease fmease deleted the compiler-mv-obj-safe-dyn-compat branch September 28, 2024 04:06
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 10, 2024
…mpat-2, r=jieyouxu

Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible"

Follow-up to rust-lang#130826.
Part of rust-lang#130852.

1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826.
2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide.
3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 10, 2024
…mpat-2, r=jieyouxu

Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible"

Follow-up to rust-lang#130826.
Part of rust-lang#130852.

1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826.
2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide.
3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 10, 2024
…mpat-2, r=jieyouxu

Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible"

Follow-up to rust-lang#130826.
Part of rust-lang#130852.

1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826.
2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide.
3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Oct 10, 2024
…mpat-2, r=jieyouxu

Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible"

Follow-up to rust-lang#130826.
Part of rust-lang#130852.

1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826.
2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide.
3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 10, 2024
…mpat-2, r=jieyouxu

Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible"

Follow-up to rust-lang#130826.
Part of rust-lang#130852.

1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826.
2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide.
3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2024
Rollup merge of rust-lang#131475 - fmease:compiler-mv-obj-safe-dyn-compat-2, r=jieyouxu

Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible"

Follow-up to rust-lang#130826.
Part of rust-lang#130852.

1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826.
2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide.
3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PG-exploit-mitigations Project group: Exploit mitigations rla-silenced Silences rust-log-analyzer postings to the PR it's added on. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants