Start leveraging the Deref/DerefMut traits #13053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Unsurprisingly needs a rebase.) |
This method has been entirely obsoleted by autoderef, so there's no reason for its existence.
Favor using '*' instead
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 23, 2022
fix: resolve path `Self` alone in value namespace Fixes rust-lang#12968
dingxiangfei2009
pushed a commit
to dingxiangfei2009/rust
that referenced
this pull request
Jul 28, 2024
… r=llogiq Add `BTreeSet` detection to the `set_contains_or_insert` lint * Detect `BTreeSet::contains` + `BTreeSet::insert` usage in the same way as with the `HashSet`. CC: `@lochetti` `@bitfield` ---- changelog: [`set_contains_or_insert`]: Handle `BTreeSet` in addition to `HashSet`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
get()method fromRefandRefMutin favor of the*operator, and removes all usage of thederef()function manually from rustc, favoring using*instead.Some of the code is a little wacky, but that's due to either #13044 or #13042