Add std::vec_ng::Vec::mut_slice_from(), mut_slice_to(), and mut_split_at() #12995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -474,6 +474,25 @@ impl<T> Vec<T> { | |||
| } | |||
|
|
|||
| #[inline] | |||
| pub fn mut_slice_from<'a>(&'a mut self, start: uint) -> &'a mut [T] { | |||
There was a problem hiding this comment.
These should be implemented as v.as_mut_slice().mut_slice_from(start) etc (i.e. just reuse the definitions for &mut []).
|
Can you add docs for these? Documentation will be required in this module when #12955 lands. |
|
I think we need to stop duplicating this kind of functionality in both places. It can be refactored so that it's implemented on both |
|
@Kroisse, this needs a rebase |
|
@alexcrichton I've done |
bors
added a commit
that referenced
this pull request
Mar 22, 2014
These functions are implemented for &mut [T], but std::vec_ng::Vec has not yet.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 27, 2024
…-false-positive, r=blyxyas
Fix doc_markdown DevOps false positive
This fixes an issue where the word "DevOps" ends up as a false positive for the `doc_markdown` lint.
In a doc comment like this
```rust
/// Call the Azure DevOps REST API.
pub fn example() {}
```
the word "DevOps" is highlighted as something which should be in backticks.
```
warning: item in documentation is missing backticks
--> src/lib.rs:1:20
|
1 | /// Call the Azure DevOps REST API.
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
= note: requested on the command line with `-W clippy::doc-markdown`
help: try
|
1 | /// Call the Azure `DevOps` REST API.
| ~~~~~~~~
warning: `example` (lib) generated 1 warning (run `cargo clippy --fix --lib -p example` to apply 1 suggestion)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.00s
```
This could be overriden with the `doc-valid-idents` configuration parameter as noted by the [documentation](https://rust-lang.github.io/rust-clippy/master/index.html#/doc_markdown), but I believe the word "DevOps" is sufficiently common to belong alongside exceptions like "GitHub" and "GitLab".
changelog: [`doc_markdown`]: Fix DevOps false positive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions are implemented for &mut [T], but std::vec_ng::Vec has not yet.