Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linkage1 test which fails due to --as-needed #12983

Closed
wants to merge 1 commit into from
Closed

Fix linkage1 test which fails due to --as-needed #12983

wants to merge 1 commit into from

Commits on Mar 17, 2014

  1. Fix linkage1 test which fails due to --as-needed 

    It appears that the --as-needed flag to linkers will not pull in a dynamic library unless it satisfies a non weak undefined symbol. The linkage1 test was creating a dynamic library where it was only used for a weak-symbol as part of an executable, so the dynamic library was getting discarded.

This commit adds another symbol to the library which satisfies a strong undefined symbol, so the library is pulled in to resolve the weak reference.
    @nrc
    nrc committed Mar 17, 2014
    4 Configuration menu
    Copy the full SHA
    f6195f5 View commit details
    Browse the repository at this point in the history