-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 1.83 #129790
Bump to 1.83 #129790
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
@bors r+ rollup=never p=1 |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (43eaa5c): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 0.4%, secondary 0.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.4%, secondary -0.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary 0.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 789.249s -> 789.934s (0.09%) |
Weird, but after that pr i can't build rust on
(Locally bumped msvc to 17.11.4, probably it's the reason?) mehh, auto update of msvc don't consistently updated toolchain, manual update fixed issue. |
Hi @klensy, I think someone else is running into this, could you elaborate what you updated? (This seems more like a msvc toolchain issue not a rust issue) |
Yes, after automatic update, need to go into modify -> individual components -> found installed build tools (was build tools 14.40-17.10), uncheck old one (to uninstall it) and select newer one (build tools 14.41-17.11), then install it. |
Thanks for the info, this is slightly funny lol. |
https://forge.rust-lang.org/release/process.html#bump-the-stable-version-number-t-6-days-friday-the-week-before