Prereq4 for async drop - needs_async_drop query fixes and some cleanup #129739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras This PR changes Stable MIR |
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
from
b667246
to
ccf830a
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
from
ccf830a
to
b193d6a
Compare
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #129817) made this pull request unmergeable. Please resolve the merge conflicts. |
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
2 times, most recently
from
e0d8585
to
aa7c159
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
from
aa7c159
to
2d5cad6
Compare
|
☔ The latest upstream changes (presumably #129313) made this pull request unmergeable. Please resolve the merge conflicts. |
…p from previous async drop glue implementation
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
from
2d5cad6
to
81c51d9
Compare
|
☔ The latest upstream changes (presumably #130165) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @nikomatsakis is going to look into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is subpart 4 PR of #123948, just for review purposes.
is_async_dropquery added, smallneeds_async_dropfixes and previous async drop glue implementation cleanup.is_async_dropfor detection of type implementing AsyncDrop trait itself,needs_async_dropfor detection if a complex type have some internals implementing AsyncDrop and requires async drop glue for itself.Review only last commit, based on previous PR #129737.