[CRATER] Crater Rollup #129660

compiler-errors · 2024-08-27T15:17:10Z

This is a " crater rollup" of:

What is a crater rollup? It's simply a crater job that is run on all of the containing PRs together, and then we can set the crates list for each of these jobs to just the failures after it's done. It should cut out on the bulk of "normal" crates that do nothing and simply just take time to build.

r? @ghost

compiler-errors · 2024-08-27T15:17:15Z

@bors try

bors · 2024-08-27T15:18:28Z

⌛ Trying commit cee59b8 with merge 7a125f7...

[CRATER] Crater Rollup This is a " crater rollup" of: * rust-lang#126452 * rust-lang#128784 * rust-lang#129392 * rust-lang#129422 * rust-lang#129543 **What is a crater rollup?** It's simply a crater job that is run on all of the containing PRs *together*, and then we can set the crates list for each of these jobs to just the failures after it's done. It should cut out on the bulk of "normal" crates that do nothing and simply just take time to build. r? `@ghost`

bors · 2024-08-27T17:13:12Z

☀️ Try build successful - checks-actions
Build commit: 7a125f7 (7a125f7a0e84bc0b8cf42bad8c31d85bc0cac361)

compiler-errors · 2024-08-27T17:20:40Z

@craterbot check p=6

Will need to do a bit of a dance once this crater run is finished, since the next job in the queue is part of this run. I'll need to set all the crates lists first, then stop and re-queue it. Anyways, just leaving a note for myself.

craterbot · 2024-08-27T17:20:48Z

👌 Experiment pr-129660 created and queued.
🤖 Automatically detected try build 7a125f7
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

compiler-errors · 2024-08-28T00:09:54Z

@craterbot cancel

compiler-errors · 2024-08-28T00:09:57Z

@bors try

craterbot · 2024-08-28T00:10:02Z

🗑️ Experiment pr-129660 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

bors · 2024-08-28T00:11:09Z

⌛ Trying commit 3dc10b8 with merge f87d382...

[CRATER] Crater Rollup This is a " crater rollup" of: * rust-lang#126452 * rust-lang#128784 * rust-lang#129392 * rust-lang#129422 * rust-lang#129543 * rust-lang#129604 **What is a crater rollup?** It's simply a crater job that is run on all of the containing PRs *together*, and then we can set the crates list for each of these jobs to just the failures after it's done. It should cut out on the bulk of "normal" crates that do nothing and simply just take time to build. r? `@ghost`

compiler-errors · 2024-08-28T00:14:48Z

crater command:

craterbot run mode=check-only start=master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 end=try#f87d38216adff5a6b0df2d9c92ea2690b8066726+rustflags=-Dtail_expr_drop_order

bors · 2024-08-28T00:23:07Z

💔 Test failed - checks-actions

…erge

compiler-errors · 2024-08-28T00:33:17Z

@bors try

[CRATER] Crater Rollup This is a " crater rollup" of: * rust-lang#126452 * rust-lang#128784 * rust-lang#129392 * rust-lang#129422 * rust-lang#129543 * rust-lang#129604 **What is a crater rollup?** It's simply a crater job that is run on all of the containing PRs *together*, and then we can set the crates list for each of these jobs to just the failures after it's done. It should cut out on the bulk of "normal" crates that do nothing and simply just take time to build. r? `@ghost`

bors · 2024-08-28T00:34:28Z

⌛ Trying commit cef7ece with merge f9935d2...

rust-log-analyzer · 2024-08-28T01:00:42Z

The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

------
 > importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:20d3b4d4a2629cbf7865cdbf92fe47512a7c96658c24253a045ff38e8075cd7fb37ca6fcadfa6e6d093333943ad24f6fc4f163ec5b74fd940de9d5bb03eb4d3b:
------
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-17]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-17', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-17/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.thin-lto-import-instr-limit := 10
configure: change-id            := 99999999
---
failures:

---- [ui] tests/ui/drop/lint-tail-expr-drop-order-gated.rs#edition_less_than_2024 stdout ----

error in revision `edition_less_than_2024`: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/drop/lint-tail-expr-drop-order-gated.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--cfg" "edition_less_than_2024" "--check-cfg" "cfg(FALSE,neither,no_feature_gate,edition_less_than_2024)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/drop/lint-tail-expr-drop-order-gated.edition_less_than_2024" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/drop/lint-tail-expr-drop-order-gated.edition_less_than_2024/auxiliary" "--edition=2021"
--- stderr -------------------------------
--- stderr -------------------------------
error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
   |
LL |     let x = LoudDropper;
LL |     let x = LoudDropper;
   |         - these values have significant drop implementation and will observe changes in drop order under Edition 2024
LL |     x.get() + LoudDropper.get()
   |
   = warning: this changes meaning in Rust 2024
   = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739>
note: the lint level is defined here
---
---- [ui] tests/ui/drop/lint-tail-expr-drop-order-gated.rs#no_feature_gate stdout ----

error in revision `no_feature_gate`: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/drop/lint-tail-expr-drop-order-gated.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--cfg" "no_feature_gate" "--check-cfg" "cfg(FALSE,neither,no_feature_gate,edition_less_than_2024)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/drop/lint-tail-expr-drop-order-gated.no_feature_gate" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/drop/lint-tail-expr-drop-order-gated.no_feature_gate/auxiliary" "-Z" "unstable-options" "--edition=2024"
--- stderr -------------------------------
--- stderr -------------------------------
error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
   |
LL |     let x = LoudDropper;
LL |     let x = LoudDropper;
   |         - these values have significant drop implementation and will observe changes in drop order under Edition 2024
LL |     x.get() + LoudDropper.get()
   |
   = warning: this changes meaning in Rust 2024
   = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739>
note: the lint level is defined here
---
---- [ui] tests/ui/drop/lint-tail-expr-drop-order-gated.rs#neither stdout ----

error in revision `neither`: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/drop/lint-tail-expr-drop-order-gated.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--cfg" "neither" "--check-cfg" "cfg(FALSE,neither,no_feature_gate,edition_less_than_2024)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/drop/lint-tail-expr-drop-order-gated.neither" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/drop/lint-tail-expr-drop-order-gated.neither/auxiliary" "--edition=2021"
--- stderr -------------------------------
--- stderr -------------------------------
error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
   |
LL |     let x = LoudDropper;
LL |     let x = LoudDropper;
   |         - these values have significant drop implementation and will observe changes in drop order under Edition 2024
LL |     x.get() + LoudDropper.get()
   |
   = warning: this changes meaning in Rust 2024
   = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739>
note: the lint level is defined here

bors · 2024-08-28T02:25:51Z

☀️ Try build successful - checks-actions
Build commit: f9935d2 (f9935d29d867449445ee008640ccca1bf1ae0889)

compiler-errors · 2024-08-28T03:32:50Z

@craterbot run mode=check-only start=master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 end=try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order p=6 name=crater-rollup-uwu

craterbot · 2024-08-28T03:32:57Z

👌 Experiment crater-rollup-uwu created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2024-08-29T02:57:35Z

🚧 Experiment crater-rollup-uwu is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

matthiaskrgr · 2024-08-31T11:07:18Z

do we check some crates twice or someting?

compiler-errors · 2024-08-31T11:08:52Z

time travel, perhaps

craterbot · 2024-08-31T12:19:32Z

🎉 Experiment crater-rollup-uwu is completed!
📊 97729 regressed and 1 fixed (506274 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

compiler-errors · 2024-08-31T12:45:36Z

This PR has served its purpose -- I have adjusted the crates lists on each experiment in this rollup.

This should shorten each job by 5x hopefully.

[CRATER] Crater rollup This is a crater rollup of: * rust-lang#124141 * rust-lang#130285 * rust-lang#130367 **What is a crater rollup?** It's simply a (manually set-up) crater job that is run on all of the containing PRs together, and then we can set the crates list for each of these jobs to *just* the list of failures after it's done. It should cut out on the bulk of "normal" crates that do nothing and simply just waste time to build without being affected by the union of all of these changes. After this is finished, I will adjust all of the jobs to use only the list of failed crates. That should significantly speed up these jobs from taking like ~6 days to taking ~2. See the last time I did this: rust-lang#129660. Given that rust-lang#130285 is running in build-and-test mode, let's run all of them in build-and-test mode.

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2024

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 27, 2024

This comment has been minimized.

Sign in to view

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2024

traviscross mentioned this pull request Aug 27, 2024

[DO NOT MERGE] crater run on the tail expression drop order lint #129604

Draft

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 28, 2024

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2024

compiler-errors added 4 commits August 27, 2024 20:23

Reserve prefix lifetimes too

687d56f

Format lexer

d3a1e52

Initial support for raw lifetimes

e6bf16c

Add some more tests

2e88dcb

tdittr and others added 9 commits August 27, 2024 20:32

Skip test case on target which supports an ABI but we expect an error

c81ff5d

Choose a platform independat ABI to ensure test can run on non x86_64

819bf6e

Be very explicit about where to run test with extern "efiapi"

6867eb6

Do not consider match/let/raw-ref of deref that evalautes to ! to div…

4b6d8d6

…erge

Do not coerce places if they do not constitute reads

7d35931

All ref operators

e96125e

Gate repr(Rust) correctly on non-ADT items

87443f3

Properly deduce the object lifetime default in GAT paths

d165f93

crater run, off the wheel chocks

cef7ece

compiler-errors force-pushed the crater-rollup branch from 3dc10b8 to cef7ece Compare August 28, 2024 00:33

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 28, 2024

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 31, 2024

matthiaskrgr mentioned this pull request Aug 31, 2024

number of "completed jobs" change after crater completed rust-lang/crater#735

Closed

compiler-errors closed this Aug 31, 2024

compiler-errors mentioned this pull request Sep 14, 2024

[CRATER] Crater rollup #130373

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CRATER] Crater Rollup #129660

[CRATER] Crater Rollup #129660

compiler-errors commented Aug 27, 2024 •

edited

Loading

compiler-errors commented Aug 27, 2024

bors commented Aug 27, 2024

This comment has been minimized.

bors commented Aug 27, 2024

compiler-errors commented Aug 27, 2024

craterbot commented Aug 27, 2024

compiler-errors commented Aug 28, 2024

compiler-errors commented Aug 28, 2024

craterbot commented Aug 28, 2024

bors commented Aug 28, 2024

compiler-errors commented Aug 28, 2024

This comment has been minimized.

This comment has been minimized.

bors commented Aug 28, 2024

compiler-errors commented Aug 28, 2024

bors commented Aug 28, 2024

rust-log-analyzer commented Aug 28, 2024

bors commented Aug 28, 2024

compiler-errors commented Aug 28, 2024

craterbot commented Aug 28, 2024

craterbot commented Aug 29, 2024

matthiaskrgr commented Aug 31, 2024

compiler-errors commented Aug 31, 2024

craterbot commented Aug 31, 2024

compiler-errors commented Aug 31, 2024

[CRATER] Crater Rollup #129660

[CRATER] Crater Rollup #129660

Conversation

compiler-errors commented Aug 27, 2024 • edited Loading

compiler-errors commented Aug 27, 2024

bors commented Aug 27, 2024

This comment has been minimized.

bors commented Aug 27, 2024

compiler-errors commented Aug 27, 2024

craterbot commented Aug 27, 2024

compiler-errors commented Aug 28, 2024

compiler-errors commented Aug 28, 2024

craterbot commented Aug 28, 2024

bors commented Aug 28, 2024

compiler-errors commented Aug 28, 2024

This comment has been minimized.

This comment has been minimized.

bors commented Aug 28, 2024

compiler-errors commented Aug 28, 2024

bors commented Aug 28, 2024

rust-log-analyzer commented Aug 28, 2024

bors commented Aug 28, 2024

compiler-errors commented Aug 28, 2024

craterbot commented Aug 28, 2024

craterbot commented Aug 29, 2024

matthiaskrgr commented Aug 31, 2024

compiler-errors commented Aug 31, 2024

craterbot commented Aug 31, 2024

compiler-errors commented Aug 31, 2024

compiler-errors commented Aug 27, 2024 •

edited

Loading