[Experimental] what if we use symlink_metadata #129469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieyouxu
added
the
S-experimental
rustbot
added
the
S-waiting-on-review
jieyouxu
removed
the
S-waiting-on-review
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 23, 2024
[Experimental] what if we use symlink_metadata r? ghost Follow up to information revealed in rust-lang#129431. The cargo branch contains a change: ```diff diff --git a/crates/cargo-util/src/paths.rs b/crates/cargo-util/src/paths.rs index 59e812f3aea..d2f023da3ce 100644 --- a/crates/cargo-util/src/paths.rs +++ b/crates/cargo-util/src/paths.rs `@@` -571,7 +571,9 `@@` where } fn set_not_readonly(p: &Path) -> io::Result<bool> { - let mut perms = p.metadata()?.permissions(); + // Note that `p` is possibly a symlink. What if this is + // `symlink_metadata`? + let mut perms = p.symlink_metadata()?.permissions(); if !perms.readonly() { return Ok(false); } ``` try-job: x86_64-msvc-ext
|
I don't think your change worked or the cargo submodule would itself also have changed |
|
d'oh. You're right. |
|
☀️ Try build successful - checks-actions |
|
Closing this for now, should try to get more info on what failed before trying to modify things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? ghost
Follow up to information revealed in #129431.
The cargo branch contains a change:
try-job: x86_64-msvc-ext