Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Remove reference to the 'extra' library #12921

Merged
merged 1 commit into from
Mar 16, 2014

Conversation

alexcrichton
Copy link
Member

Forgot to remove this as part of the previous removal of libextra

Forgot to remove this as part of the previous removal of libextra
bors added a commit that referenced this pull request Mar 15, 2014
Forgot to remove this as part of the previous removal of libextra
@bors bors closed this Mar 16, 2014
@bors bors merged commit cdd8d48 into rust-lang:master Mar 16, 2014
@alexcrichton alexcrichton deleted the no-extra branch March 17, 2014 03:48
lnicola pushed a commit to lnicola/rust that referenced this pull request Aug 16, 2022
fix: make `concat!` work with char

Fixes rust-lang#12921

- I avoided making `unquote_str()` take char literals as well because it's depended on by another function `parse_string()` that's only supposed to take strings.
- Even with this patch, we don't output `\0` as `\u{0}` which rust-lang#12921 pointed out ~~, but we're not actually responsible for serializing it but rowan is~~. They are functionally equivalent and I don't think it'd cause any confusion, but we *could* try escaping them before serialization (for reference, `rustc -Zunpretty=expanded`, which `cargo expand` uses under the hood, [makes use of `str::escape_default()`](https://github.com/rust-lang/rust/blob/3830ecaa8db798d2727cbdfa4ddf314ff938f268/compiler/rustc_ast/src/util/literal.rs#L161).
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants