Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diagnostic-related lints: untranslatable_diagnostic & diagnostic_outside_of_impl #128941

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Improve diagnostic-related lints: untranslatable_diagnostic & diagnostic_outside_of_impl #128941

merged 3 commits into from
Aug 22, 2024

Commits on Aug 10, 2024

  1. Add more test cases for untranslatable_diagnostic lint

    @GrigorenkoPV
    GrigorenkoPV committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    10ef666 View commit details
    Browse the repository at this point in the history

  2. untranslatable_diagnostic lint: point at the untranslated thing 

    and not the function/method call
    @GrigorenkoPV
    GrigorenkoPV committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    3cc2a6f View commit details
    Browse the repository at this point in the history

  3. Refactor: diagnostic_outside_of_impl, untranslatable_diagnostic 

    1. Decouple them.
2. Make logic around `diagnostic_outside_of_impl`'s early exits simpler.
3. Make `untranslatable_diagnostic` run one loop instead of two
   and not allocate an intermediate vec.
4. Overall, reduce the amount of code executed
   when the lints do not end up firing.
    @GrigorenkoPV
    GrigorenkoPV committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    e94a4ee View commit details
    Browse the repository at this point in the history