Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #127991

Closed
wants to merge 30 commits into from
Closed

Commits on Jul 10, 2024

  1. Replace a long inline "autoref" comment with method docs

    This comment has two problems:
    
    - It is very long, making the flow of the enclosing method hard to follow.
    - It starts by talking about an `autoref` flag that hasn't existed since rust-lang#59114.
    
    This PR therefore replaces the long inline comment with a revised doc comment
    on `bind_matched_candidate_for_guard`, and some shorter inline comments.
    
    For readers who want more historical context, we also link to the PR that added
    the old comment, and the PR that removed the `autoref` flag.
    Zalathar committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    83e1efb View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    ec6e07b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eea6502 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5483945 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f54fa62 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Configuration menu
    Copy the full SHA
    a605e2f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    939ee38 View commit details
    Browse the repository at this point in the history
  3. Style change

    ChrisDenton committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    8e4a920 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9432955 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. fixes panic error

    surechen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    9747a2c View commit details
    Browse the repository at this point in the history
  2. uefi: Add process

    Signed-off-by: Ayush Singh <[email protected]>
    Ayush1325 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    a8d7121 View commit details
    Browse the repository at this point in the history
  3. uefi: process: Add support to capture stdout

    Use a custom simple_text_output protocol to capture output.
    
    Signed-off-by: Ayush Singh <[email protected]>
    Ayush1325 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6737a02 View commit details
    Browse the repository at this point in the history
  4. uefi: process: Add stderr support

    Implement stderr support in similar fashion.
    
    Signed-off-by: Ayush Singh <[email protected]>
    Ayush1325 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    87d7a07 View commit details
    Browse the repository at this point in the history
  5. uefi: process: Add null protocol

    Signed-off-by: Ayush Singh <[email protected]>
    Ayush1325 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    7253765 View commit details
    Browse the repository at this point in the history
  6. uefi: process Implement inherit

    Only tested in 2 levels right now. Need args support for 3 levels
    
    Signed-off-by: Ayush Singh <[email protected]>
    Ayush1325 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d44b3fb View commit details
    Browse the repository at this point in the history
  7. uefi: process: Add support for args

    Also fix stdio inherit
    
    Signed-off-by: Ayush Singh <[email protected]>
    Ayush1325 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    29c198c View commit details
    Browse the repository at this point in the history
  8. uefi: process: Add CommandArgs support

    Signed-off-by: Ayush Singh <[email protected]>
    Ayush1325 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c899e05 View commit details
    Browse the repository at this point in the history
  9. uefi: process: Final Touchups

    Signed-off-by: Ayush Singh <[email protected]>
    Ayush1325 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    56e2a57 View commit details
    Browse the repository at this point in the history
  10. uefi: process: Fixes from PR

    - Update system table crc32
    - Fix unsound use of Box
    - Free exit data
    - Code improvements
    - Introduce OwnedTable
    - Update r-efi to latest version
    - Use extended_varargs_abi_support for
      install_multiple_protocol_interfaces and
      uninstall_multiple_protocol_interfaces
    - Fix comments
    - Stub out args implementation
    
    Signed-off-by: Ayush Singh <[email protected]>
    Ayush1325 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    e290398 View commit details
    Browse the repository at this point in the history
  11. Conditionally build wasm-component-ld

    This commit updates the support for the `wasm-component-ld` tool
    from rust-lang#126967 to conditionally build it rather than unconditionally
    building it when LLD is enabled. This support is disabled by default and
    can be enabled by one of two means:
    
    * the `extended` field in `config.toml` which dist builders use to build
      a complete set of tools for each host platform.
    * a `"wasm-component-ld"` entry in the `tools` section of `config.toml`.
    
    Neither of these are enabled by default meaning that most local builds
    will likely not have this new tool built. Dist builders should still,
    however, build the tool.
    alexcrichton committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    ae82726 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f0a2b5b View commit details
    Browse the repository at this point in the history
  13. Avoid ref when using format! in compiler

    Clean up a few minor refs in `format!` macro, as it has a performance cost. Apparently the compiler is unable to inline `format!("{}", &variable)`, and does a run-time double-reference instead (format macro already does one level referencing).  Inlining format args prevents accidental `&` misuse.
    nyurik committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    aef0e34 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#123196 - Ayush1325:uefi-process, r=joboet

    Add Process support for UEFI
    
    UEFI does not have an actual process. However, it does provide methods to launch and execute another UEFI image. Having process support is important since it is possible to run rust test suit using `Command::output` and is the first step towards being able to run it for UEFI.
    
    Here is an overview of how the support is implemented.
    
    - We create a copy of the SystemTable. This is required since at least OVMF seems to crash if the original system table is modified.
    - Stdout and Stderr pipe works by registering a new `simple_text_output` Protocol and pointing the child system table to use those.
    - `Stdio::Inherit` just points the console to the current running image console which seems to work with even 3 levels of process.
    - `spawn` is left unimplemented since it does not make sense for UEFI architecture. Additionally, since rust-lang#105458 was merged, the `spawn` and `output` implementations are completely independent.
    tgross35 authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    452bfb8 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#127523 - Oneirical:treasure-test, r=jieyouxu

    Migrate `dump-ice-to-disk` and `panic-abort-eh_frame` `run-make` tests to rmake
    
    Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
    
    Please try:
    
    try-job: x86_64-msvc
    tgross35 authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    77b75f9 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#127556 - Zalathar:autoref, r=Nadrieril

    Replace a long inline "autoref" comment with method docs
    
    This comment has two problems:
    
    - It is very long, making the flow of the enclosing method hard to follow.
    - It starts by talking about an `autoref` flag that hasn't existed since rust-lang#59114.
      - This makes it hard to trust that the information in the comment is accurate or relevant, even though much of it still seems to be true.
    
    This PR therefore replaces the long inline comment with a revised doc comment on `bind_matched_candidate_for_guard`, and some shorter inline comments.
    
    For readers who want more historical context, we also link to the PR that added the old comment, and the PR that removed the `autoref` flag.
    tgross35 authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5fc6649 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#127693 - Rejyr:migrate-crate-hash-rustc-ver…

    …sion-rmake, r=jieyouxu
    
    Migrate `crate-hash-rustc-version` to `rmake`
    
    Part of rust-lang#121876.
    
    r? `@jieyouxu`
    
    try-job: x86_64-gnu-llvm-18
    try-job: dist-x86_64-linux
    tgross35 authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    52fe840 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#127866 - alexcrichton:disable-wasm-componen…

    …t-ld-by-default, r=onur-ozkan
    
    Conditionally build `wasm-component-ld`
    
    This commit updates the support for the `wasm-component-ld` tool from rust-lang#126967 to conditionally build rather than unconditionally building it when LLD is enabled. This support is disabled by default and can be enabled by one of two means:
    
    * the `extended` field in `config.toml` which dist builders use to build a complete set of tools for each host platform.
    * a `"wasm-component-ld"` entry in the `tools` section of `config.toml`.
    
    Neither of these are enabled by default meaning that most local builds will likely not have this new tool built. Dist builders should still, however, build the tool.
    tgross35 authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    e6e41fc View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#127918 - ChrisDenton:thread-name-string, r=…

    …joboet
    
    Safely enforce thread name requirements
    
    The requirements for the thread name to be both UTF-8 and null terminated are easily enforced by a wrapper type so lets do that. The fact this used to be just a bare `CString` has tripped me up before because it was entirely safe to use a non UTF-8 `CString`.
    tgross35 authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1ab7233 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#127948 - surechen:fix_127915, r=compiler-er…

    …rors
    
    fixes panic error `index out of bounds` in conflicting error
    
    fixes rust-lang#127915
    tgross35 authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5dbe933 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#127980 - nyurik:compiler-refs, r=oli-obk

    Avoid ref when using format! in compiler
    
    Clean up a few minor refs in `format!` macro, as it has a performance cost. Apparently the compiler is unable to inline `format!("{}", &variable)`, and does a run-time double-reference instead (format macro already does one level referencing).  Inlining format args prevents accidental `&` misuse.
    
    See also rust-lang/rust-clippy#10851
    tgross35 authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d2d24cf View commit details
    Browse the repository at this point in the history