Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #127635

Merged
merged 20 commits into from
Jul 12, 2024
Merged

Rollup of 6 pull requests #127635

merged 20 commits into from
Jul 12, 2024

Commits on Jul 6, 2024

  1. Configuration menu
    Copy the full SHA
    585ca16 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Move a function

    Nadrieril committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5bf50e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bff4d21 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c5062f7 View commit details
    Browse the repository at this point in the history
  4. Don't try to save an extra block

    This is preparation for the next commit.
    Nadrieril committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    8a222ff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fc40247 View commit details
    Browse the repository at this point in the history
  6. Return the otherwise_block instead of passing it as argument

    This saves a few blocks and matches the common `unpack!` paradigm.
    Nadrieril committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    3e030b3 View commit details
    Browse the repository at this point in the history
  7. Address review comments

    Nadrieril committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    42772e9 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    08a2992 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b77d3ef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d902179 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d9170dc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    872d7b8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a776e5f View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Rollup merge of rust-lang#127164 - Nadrieril:clean-lowering-loop, r=m…

    …atthewjasper
    
    match lowering: Clarify the main loop of the algorithm
    
    Now that we expand or-patterns in a single place in the algorithm, we can move it (back) to the main part of the loop. This makes the call-graph of the main loop rather simple: `match_candidates` has three branches that each call back to `match_candidates`. The remaining tricky part is `finalize_or_candidate`.
    
    I also factored out the whole "process a prefix of the candidates then process the rest" thing which I think helps legibility.
    
    The first two commits are a fix for an indexing mistake I introduced in rust-lang#126553, already sumitted in rust-lang#127028 but feel free to merge this first.
    
    r? `@matthewjasper`
    matthiaskrgr authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    58fe37f View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#127422 - greaka:master, r=workingjubilee

    as_simd: fix doc comment to be in line with align_to
    
    In rust-lang#121201, the guarantees about `align_offset` and `align_to` were changed. This PR aims to correct the doc comment of `as_simd` to be in line with the new `align_to`.
    
    Tagging rust-lang#86656 for good measure.
    matthiaskrgr authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    1e7ad4c View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#127596 - tesuji:help-unwrap-or, r=compiler-…

    …errors
    
    More suggestion for converting `Option<&Vec<T>>` to `Option<&[T]>`
    
    Please review commit-by-commit.
    matthiaskrgr authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    83d1a1b View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#127607 - Zalathar:normalize-hint, r=wesleyw…

    …iser
    
    compiletest: Better error message for bad `normalize-*` headers
    
    Follow-up to rust-lang#126777.
    
    Example of the new error message in context:
    ```text
    ---- [ui] tests/ui/rfcs/rfc-2632-const-trait-impl/effects/minicore.rs stdout ----
    thread '[ui] tests/ui/rfcs/rfc-2632-const-trait-impl/effects/minicore.rs' panicked at src/tools/compiletest/src/header.rs:1001:13:
    couldn't parse custom normalization rule: `normalize-stderr-test ".*note: .*\n\n" -> ""`
    help: expected syntax is: `normalize-stderr-test: "REGEX" -> "REPLACEMENT"`
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
    ```
    matthiaskrgr authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    fe564c1 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#127622 - compiler-errors:builtin-internal, …

    …r=lqd
    
    Mark `builtin_syntax` as internal
    
    Tracking issue literally says:
    
    > There will never be a general stabilization.
    
    cc rust-lang#110680 `@est31`
    matthiaskrgr authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ca576ea View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#127625 - SkiFire13:revert-comment-deletion,…

    … r=workingjubilee
    
    Revert accidental comment deletion
    
    This reverts an accidental comment deletion made in rust-lang#113128
    
    See also rust-lang#113128 (comment)
    matthiaskrgr authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c2b7842 View commit details
    Browse the repository at this point in the history