Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ast MutVisitor have the same method name and style as Visitor #127524

Merged
merged 10 commits into from
Jul 24, 2024
Merged

Make ast MutVisitor have the same method name and style as Visitor #127524

merged 10 commits into from
Jul 24, 2024

Commits on Jul 22, 2024

  1. Merge impl and trait item mut visitor methods to mirror immut visitor

    @oli-obk
    oli-obk committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    5241d8b View commit details
    Browse the repository at this point in the history

  2. Track visit_param_bound in mut visit just like in the immutable visitor

    @oli-obk
    oli-obk committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    c064b36 View commit details
    Browse the repository at this point in the history

  3. Make function items in mut visitors all go through the same visit_fn … 

    …function, just like with immutable visitors
    @oli-obk
    oli-obk committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    1b9ac00 View commit details
    Browse the repository at this point in the history

  4. Pass id and span to visit_fn, just like for the immutable visitor

    @oli-obk
    oli-obk committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    545553c View commit details
    Browse the repository at this point in the history

  5. Split up visit_path so MutVisitor has a path_segment method jus… 

    …t like the immutable visitor
    @oli-obk
    oli-obk committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    e426f26 View commit details
    Browse the repository at this point in the history

  6. Add Ident to FnKind::Fn, just like with the immutable visitor

    @oli-obk
    oli-obk committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6f85f20 View commit details
    Browse the repository at this point in the history

  7. Sync mut_visit function names with immut visit ones (s/noop_visit… 

    …/walk/)
    @oli-obk
    oli-obk committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    754bdef View commit details
    Browse the repository at this point in the history

  8. Always pass the visitor as the first argument to walk* functions

    @oli-obk
    oli-obk committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    8d29005 View commit details
    Browse the repository at this point in the history

  9. Update trait name from Noop -> Walk

    @oli-obk
    oli-obk committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    91b26fc View commit details
    Browse the repository at this point in the history

  10. Avoid passing state that will not be visited

    @oli-obk
    oli-obk committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    e9f32d0 View commit details
    Browse the repository at this point in the history