Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use verbose suggestion for changing arg type #127392

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Use verbose suggestion for changing arg type #127392

merged 1 commit into from
Jul 6, 2024

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Jul 5, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 5, 2024
jieyouxu
jieyouxu approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@bors r+ rollup

@jieyouxu
Copy link
Member

jieyouxu commented Jul 6, 2024

oh right, bors doesn't pickup the r+ from the approve message.
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 6, 2024

📌 Commit 7569205 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 6, 2024
@matthiaskrgr
Rollup merge of rust-lang#127392 - estebank:arg-type, r=jieyouxu
800aec4 
Use verbose suggestion for changing arg type
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 6, 2024
Closed
@workingjubilee workingjubilee mentioned this pull request Jul 6, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 6, 2024
@bors
Auto merge of rust-lang#127414 - workingjubilee:rollup-lcxw1eh, r=wor…
28cc0b6 
…kingjubilee

Rollup of 5 pull requests

Successful merges:

 - rust-lang#125751 (Add `new_range_api` for RFC 3550)
 - rust-lang#127098 (Migrate `output-type-permutations` `run-make` test to rmake)
 - rust-lang#127369 (Match ergonomics 2024: align with RFC again)
 - rust-lang#127383 (Use verbose style for argument removal suggestion)
 - rust-lang#127392 (Use verbose suggestion for changing arg type)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8531487 into rust-lang:master Jul 6, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 6, 2024
@rust-timer
Unrolled build for rust-lang#127392
cb41705 
Rollup merge of rust-lang#127392 - estebank:arg-type, r=jieyouxu

Use verbose suggestion for changing arg type
@rustbot rustbot added this to the 1.81.0 milestone Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
4 participants
@estebank @rustbot @jieyouxu @bors