-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate use-suggestions-rust-2018
, overwrite-input
, lto-dylib-dep
and many-crates-but-no-match
run-make
tests to rmake
#127000
Conversation
This PR modifies cc @jieyouxu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Since this already contains 5 tests, I'd move the UI test port to a different PR, and we can try to merge this one without msvc-opt-minsize
.
669d273
to
b94eae5
Compare
I just dropped it from this PR. |
use-suggestions-rust-2018
, overwrite-input
, lto-dylib-dep
, msvc-opt-minsize
and many-crates-but-no-match
run-make
tests to rmakeuse-suggestions-rust-2018
, overwrite-input
, lto-dylib-dep
and many-crates-but-no-match
run-make
tests to rmake
Okay, here goes nothing. @bors r+ rollup=iffy |
…Kobzol Migrate `use-suggestions-rust-2018`, `overwrite-input`, `lto-dylib-dep` and `many-crates-but-no-match` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry ? |
☀️ Test successful - checks-actions |
Finished benchmarking commit (c4c0897): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary -2.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -2.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 696.308s -> 696.756s (0.06%) |
Part of #121876 and the associated Google Summer of Code project.