Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #124628

Closed
wants to merge 19 commits into from
Closed

Rollup of 8 pull requests #124628

wants to merge 19 commits into from

Commits on Apr 24, 2024

  1. Configuration menu
    Copy the full SHA
    a51ad79 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b1fd4a7 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Configuration menu
    Copy the full SHA
    1367827 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Configuration menu
    Copy the full SHA
    65d7478 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. library/std: Remove unused gimli-symbolize feature

    library/backtrace also declares a feature called `gimli-symbolize` which
    appear used, but the feature in std with the same name is unused, so
    remove it.
    Enselic committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9af3b1e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c15558 View commit details
    Browse the repository at this point in the history
  3. compiletest: add no-auto-check-cfg directive

    this directive prevents compiletest from adding any implicit and
    automatic --check-cfg arguments
    Urgau committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a96964d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    595ddb0 View commit details
    Browse the repository at this point in the history
  5. shallow resolve in orphan check

    lcnr committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c4e882f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    09aa772 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    dba1849 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#124138 - mati865:ignore-llvm-abi-in-dlltool…

    …-tests, r=davidtwco
    
    Ignore LLVM ABI in dlltool tests since those targets don't use dlltool
    
    Otherwise those two tests fail when running `./x.py test` with this target.
    fmease authored May 2, 2024
    Configuration menu
    Copy the full SHA
    1bbe36b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#124345 - Urgau:compiletest-check-cfg, r=jie…

    …youxu
    
    Enable `--check-cfg` by default in UI tests
    
    This PR enables-by-default `--check-cfg` in UI tests, now that it has become stable.
    
    To do so this PR does 2 main things:
     - it introduce the `no-auto-check-cfg` directive to `compiletest`, to prevent any `--check-cfg` args (only to be used for `--check-cfg` tests)
     - it updates the _remaining_[^1] UI tests by either:
         - allowing the lint when neither expecting the lint nor giving the check-cfg args make sense
         - give the appropriate check-cfg args
         - or expect the lint, when it useful
    
    [^1]: some preparation work was done in rust-lang#123577 rust-lang#123702
    
    I highly recommend reviewing this PR commit-by-commit.
    
    r? `@jieyouxu`
    fmease authored May 2, 2024
    Configuration menu
    Copy the full SHA
    a56f12e View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#124414 - lqd:subdiagnostics, r=davidtwco

    remove extraneous note on `UnableToRunDsymutil` diagnostic
    
    If I understand [this FIXME](https://github.com/rust-lang/rust/blob/1367827eac3d813a261a4c444037af9736996daa/compiler/rustc_macros/src/diagnostics/diagnostic.rs#L205) correctly, it seems we don't yet validate subdiagnostics, so `#[note]` and co in the `#[derive(Diagnostic]` item could be out-of-sync with the fluent message, without causing compile errors.
    
    It was the case for `rustc_codegen_ssa::errors::UnableToRunDsymutil`, causing the ICE in rust-lang#124392.
    
    I've grepped and scripted my way through most of our diagnostics structs and fluent bundles and the above was the only such extraneous `#[note]`/`#[note(name)]`/`#[help]`/`#[warning]` I could find, so hopefully there aren't many others like it.
    
    I haven't checked if the opposite can happen, a `.note = ` in a fluent message that is lacking a corresponding `#[note]` on the struct and not causing an error, but maybe it's possible?
    
    r? `@davidtwco`
    fixes rust-lang#124392
    fmease authored May 2, 2024
    Configuration menu
    Copy the full SHA
    811a27f View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#124579 - RalfJung:align-bytes-usize, r=fmease

    Align: add bytes_usize and bits_usize
    
    This matches `Size::bytes/bits_usize`. I recently wanted this in Miri as well.
    fmease authored May 2, 2024
    Configuration menu
    Copy the full SHA
    d556379 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#124604 - Enselic:std-gimli-symbolize, r=wor…

    …kingjubilee
    
    library/std: Remove unused `gimli-symbolize` feature
    
    library/backtrace also declares a feature called `gimli-symbolize` which appear used, but the feature in std with the same name is unused, so remove it.
    fmease authored May 2, 2024
    Configuration menu
    Copy the full SHA
    b7833a2 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#124622 - fmease:yeet-extern-crate-run_make_…

    …support, r=jieyouxu
    
    Cleanup: Rid the `rmake` test runners of `extern crate run_make_support;`
    
    `run_make_support` is part of the *extern prelude* of `rmake` test runners rendering `extern crate run_make_support` redundant:
    
    https://github.com/rust-lang/rust/blob/80451a485b006bd32732c003a54ee7de457d8266/src/tools/compiletest/src/runtest.rs#L3826-L3827
    
    ~~Contains some fmt'ing changes because I've enabled format-on-save in my editor and because we don't run `x fmt` for `rmake` test runners yet (this gets addressed by rust-lang#124613). I can revert those if you'd like me to.~~ (reverted)
    
    r? jieyouxu or testing-devex(?) or boostrap(?)
    fmease authored May 2, 2024
    Configuration menu
    Copy the full SHA
    159ab18 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#124623 - lcnr:coherence-uwu, r=compiler-errors

    shallow resolve in orphan check
    
    r? `@compiler-errors` cc rust-lang#124588 (review)
    fmease authored May 2, 2024
    Configuration menu
    Copy the full SHA
    ba70a5b View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#124627 - RalfJung:interpret-doc-no-inline, …

    …r=fmease
    
    interpret: hide some reexports in rustdoc
    
    Cc rust-lang#124608
    fmease authored May 2, 2024
    Configuration menu
    Copy the full SHA
    aba8ee4 View commit details
    Browse the repository at this point in the history