Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: Clean up mcdc_bitmap_bytes and conditions_num #124571

Closed
wants to merge 4 commits into from
Closed

coverage: Clean up mcdc_bitmap_bytes and conditions_num #124571

wants to merge 4 commits into from

Commits on May 6, 2024

  1. coverage: CoverageIdsInfo::mcdc_bitmap_bytes is never needed 

    This code for recalculating `mcdc_bitmap_bytes` doesn't provide any benefit,
because its result won't have changed from the value in `FunctionCoverageInfo`
that was computed during the MIR instrumentation pass.
    @Zalathar
    Zalathar committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a9b2f1b View commit details
    Browse the repository at this point in the history

  2. coverage: Remove confusing comments from CoverageKind 

    These comments appear to be inspired by the similar comments on
`CounterIncrement` and `ExpressionUsed`. But those comments refer to specific
simplification steps performed during coverage codegen, and there is no
corresponding step for the MC/DC coverage statements.
    @Zalathar
    Zalathar committed May 6, 2024
    Configuration menu
    Copy the full SHA
    0bd92bf View commit details
    Browse the repository at this point in the history

  3. coverage: Add tests for the MC/DC condition limit

    @Zalathar
    Zalathar committed May 6, 2024
    Configuration menu
    Copy the full SHA
    eb1b9e0 View commit details
    Browse the repository at this point in the history

  4. coverage: Rename conditions_num to num_conditions 

    This field counts the number of conditions that contribute to a particular
decision, but the name "conditions num" sounds like an ID instead of a count,
so "num conditions" is clearer.
    @Zalathar
    Zalathar committed May 6, 2024
    Configuration menu
    Copy the full SHA
    1a701d4 View commit details
    Browse the repository at this point in the history