Use probes more aggressively in new solver #124415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
lqd
reviewed
Apr 26, 2024
This comment has been minimized.
This comment has been minimized.
lcnr
reviewed
Apr 27, 2024
lcnr
reviewed
Apr 27, 2024
compiler-errors
force-pushed
the
candidates
branch
2 times, most recently
from
68734ca
to
2f44e5c
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
candidates
branch
from
2f44e5c
to
15381bb
Compare
|
r=me after removing the "lol" comment :3 |
compiler-errors
force-pushed
the
candidates
branch
from
15381bb
to
2eb7c81
Compare
|
@bors + rollup=always |
|
@bors r=lcnr rollup=always |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 29, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#124269 (Pretty-print parenthesis around binary in postfix match) - rust-lang#124415 (Use probes more aggressively in new solver) - rust-lang#124475 (Remove direct dependencies on lazy_static, once_cell and byteorder) - rust-lang#124484 (Fix rust-lang#124478 - offset_of! returns a temporary) - rust-lang#124504 (Mark unions non-const-propagatable in `KnownPanicsLint` without calling layout) - rust-lang#124508 (coverage: Avoid hard-coded values when visiting logical ops) - rust-lang#124522 ([Refactor] Rename `Lint` and `LintGroup`'s `is_loaded` to `is_externally_loaded` ) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 29, 2024
Rollup merge of rust-lang#124415 - compiler-errors:candidates, r=lcnr Use probes more aggressively in new solver ....so that we have the right candidate information when assembling trait and normalizes-to goals. Also gets rid of misc probes. r? lcnr
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 1, 2024
Rewrite select (in the new solver) to use a `ProofTreeVisitor` We can use a proof tree visitor rather than collecting and recomputing all the nested goals ourselves. Based on rust-lang#124415
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2024
Rewrite select (in the new solver) to use a `ProofTreeVisitor` We can use a proof tree visitor rather than collecting and recomputing all the nested goals ourselves. Based on rust-lang#124415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
....so that we have the right candidate information when assembling trait and normalizes-to goals.
Also gets rid of misc probes.
r? lcnr