-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target docs for aarch64-apple-darwin (M1/M2 macs) #124134
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Nilstrieb |
r? Nilstrieb |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Laine Taffin Altman <[email protected]>
This comment has been minimized.
This comment has been minimized.
The job Click to see the possible cause of the failure (guessed by this bot)
|
Just add it to the `target` with: | ||
```sh | ||
rustup target add aarch64-apple-darwin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section is supposed to be for building rustc
such that it includes the target, not just for building code that uses the target. Although looking at the other documents it's kind of inconsistently used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command for building the target std is always the same, so I think this should be fine.
@rustbot label O-macos O-AArch64 A-docs |
#124146 may be useful to note? |
I've documented this target (and more) in #124772 too. |
Hmm, not sure what you mean by that? I've added documentation about it to the more general |
My mistake I misread. Your docs are good so I will close this pull, I look foreword to reading the new pages. |
Add target documentation for
aarch64-apple-darwin
; 64-bit ARM-based macs running macOS, specifically Macs with "M" series Apple Silicon chips."M" series macs are quite popular so it would be useful to have some docs.