Improve diagnostic by suggesting to remove visibility qualifier #123841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
S-waiting-on-review
wesleywiser
approved these changes
Apr 12, 2024
|
Nice! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#123204 (rustdoc: point at span in `include_str!`-ed md file) - rust-lang#123223 (Fix invalid silencing of parsing error) - rust-lang#123249 (do not add prolog for variadic naked functions) - rust-lang#123825 (Call the panic hook for non-unwind panics in proc-macros) - rust-lang#123833 (Update stdarch submodule) - rust-lang#123841 (Improve diagnostic by suggesting to remove visibility qualifier) - rust-lang#123849 (Update E0384.md) - rust-lang#123852 (fix typo in library/std/src/lib.rs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2024
Rollup merge of rust-lang#123841 - Kohei316:remove_qualifier_sugg, r=wesleywiser Improve diagnostic by suggesting to remove visibility qualifier Resolves rust-lang#123529 This PR improve diagnostic by suggesting to remove visibility qualifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #123529
This PR improve diagnostic by suggesting to remove visibility qualifier.