Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 3 pull requests #123771

Closed
wants to merge 8 commits into from

Commits on Apr 5, 2024

  1. Configuration menu
    Copy the full SHA
    3d0ed4a View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Tweak value suggestions in borrowck and hir_analysis

    Unify the output of `suggest_assign_value` and `ty_kind_suggestion`.
    
    Ideally we'd make these a single function, but doing so would likely require modify the crate dependency tree.
    estebank committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    a983dd8 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Configuration menu
    Copy the full SHA
    e17388b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    acd4e94 View commit details
    Browse the repository at this point in the history
  3. Handle more cases of "values to suggest" given a type

    Add handling for `String`, `Box`, `Option` and `Result`.
    estebank committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1eda056 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Rollup merge of rust-lang#123490 - niluxv:strict_prov_unwind_seh, r=A…

    …manieu
    
    Refactor `panic_unwind/seh.rs` pointer use
    
    * `x86` now conforms to strict-provenance
    * `x86_64` now uses the expose API (instead of `as` casts)
    * changed `ptr_t` from a type alias to a `repr(transparent)` struct for some extra type-safety
    * replaced the `ptr!` macro by methods on `ptr_t`, as there is now no reason (as far as I can see) anymore to use a macro
    
    On `x86_64` pointers in SEH are represented by 32-bit offsets from `__ImageBase`, so we can't use a pointer type. It might be possible to leak the provenance into the FFI by using a `MaybeUninit<u32>` instead of a `u32`, but that is a bit more involved than using expose, and I'm not sure that would be worth it.
    matthiaskrgr authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ecf5515 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#123704 - estebank:diag-changes, r=compiler-…

    …errors
    
    Tweak value suggestions in `borrowck` and `hir_analysis`
    
    Unify the output of `suggest_assign_value` and `ty_kind_suggestion`.
    
    Ideally we'd make these a single function, but doing so would likely require modify the crate dependency tree.
    matthiaskrgr authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    cd623c0 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#123753 - Urgau:compiletest-trailing-directi…

    …ve, r=jieyouxu
    
    compiletest: error when finding a trailing directive
    
    This PR introduce a supplementary check that when checking for a compiletest directive, will also check that the next "word" after that directive is not also by itself a directive.
    
    This is done to avoid situations like this `//@ only-linux only-x86_64` where one might think that both directives are being taken into account while in fact the second in a comment, and so was ignored, until now.
    
    Related to rust-lang#123730
    cc `@scottmcm`
    r? `@jieyouxu`
    matthiaskrgr authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    249d475 View commit details
    Browse the repository at this point in the history