Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run-make-support: tidy up support library #123699

Merged
merged 4 commits into from
Apr 14, 2024
Merged

run-make-support: tidy up support library #123699

merged 4 commits into from
Apr 14, 2024

Commits on Apr 13, 2024

  1. run-make-support: make handle_failed_output take a &Command

    @jieyouxu
    jieyouxu committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    e994534 View commit details
    Browse the repository at this point in the history

  2. run-make-support: introduce macro for common methods to avoid repetition 

    Add a helper macro for adding common methods to command wrappers. Common
methods include helpers that delegate to `Command` and running methods.

- `arg` and `args` (delegates to `Command`)
- `env`, `env_remove` and `env_clear` (delegates to `Command`)
- `output`, `run` and `run_fail`

This helps to avoid needing to copy-pasta / reimplement these common
methods on a new command wrapper, which hopefully reduces the friction
for run-make test writers wanting to introduce new command wrappers.
    @jieyouxu
    jieyouxu committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    b22099d View commit details
    Browse the repository at this point in the history

  3. run-make-support: use macro to implement common methods 

    Removes the manual copy-pasta'd implementation of common methods.
    @jieyouxu
    jieyouxu committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    3d115b9 View commit details
    Browse the repository at this point in the history

  4. run-make-support: add some top-level docs

    @jieyouxu
    jieyouxu committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    a67a119 View commit details
    Browse the repository at this point in the history