-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove debuginfo from rustc-demangle too #123608
Conversation
This is done for the same reason as the other dependencies in this list.
@Mark-Simulacrum: no appropriate reviewer found, use |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…try> Remove debuginfo from rustc-demangle too This is done for the same reason as the other dependencies in this list.
☀️ Try build successful - checks-actions |
1 similar comment
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (a89e436): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 665.855s -> 667.693s (0.28%) |
r? @Kobzol perhaps? |
r=me (I think Jakub has some vacation this week) |
I think that it's fine to remove this, hopefully no one is going to debug @bors r+ (My vacation starts tomorrow 😁) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (75fd074): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 666.9s -> 668.863s (0.29%) |
This is done for the same reason as the other dependencies in this list.