Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debuginfo from rustc-demangle too #123608

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Mark-Simulacrum
Copy link
Member

This is done for the same reason as the other dependencies in this list.

This is done for the same reason as the other dependencies in this list.
@rustbot
Copy link
Collaborator

rustbot commented Apr 7, 2024

@Mark-Simulacrum: no appropriate reviewer found, use r? to override

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 7, 2024
@Mark-Simulacrum
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 7, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2024
…try>

Remove debuginfo from rustc-demangle too

This is done for the same reason as the other dependencies in this list.
@bors
Copy link
Contributor

bors commented Apr 7, 2024

⌛ Trying commit f946bf4 with merge a89e436...

@bors
Copy link
Contributor

bors commented Apr 8, 2024

☀️ Try build successful - checks-actions
Build commit: a89e436 (a89e43652a9c9664e674f08fa296acba4a3dcf1a)

1 similar comment
@bors
Copy link
Contributor

bors commented Apr 8, 2024

☀️ Try build successful - checks-actions
Build commit: a89e436 (a89e43652a9c9664e674f08fa296acba4a3dcf1a)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a89e436): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.1% [-2.6%, -0.4%] 9
Improvements ✅
(secondary)
-1.2% [-2.2%, -0.3%] 27
All ❌✅ (primary) -1.1% [-2.6%, -0.4%] 9

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.4% [3.1%, 3.7%] 2
Regressions ❌
(secondary)
3.1% [0.8%, 6.7%] 30
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.4% [3.1%, 3.7%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.8% [-2.6%, -1.3%] 4
Improvements ✅
(secondary)
-1.5% [-1.9%, -1.3%] 7
All ❌✅ (primary) -1.8% [-2.6%, -1.3%] 4

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.3% [-3.6%, -0.3%] 16
Improvements ✅
(secondary)
-3.3% [-3.6%, -2.1%] 37
All ❌✅ (primary) -1.3% [-3.6%, -0.3%] 16

Bootstrap: 665.855s -> 667.693s (0.28%)
Artifact size: 318.49 MiB -> 318.29 MiB (-0.06%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 8, 2024
@Mark-Simulacrum Mark-Simulacrum marked this pull request as ready for review April 8, 2024 11:24
@Mark-Simulacrum
Copy link
Member Author

r? @Kobzol perhaps?

@lqd
Copy link
Member

lqd commented Apr 8, 2024

r=me (I think Jakub has some vacation this week)

@Kobzol
Copy link
Contributor

Kobzol commented Apr 8, 2024

I think that it's fine to remove this, hopefully no one is going to debug rustc-demangle in our toolchain. Nice binary size wins.

@bors r+

(My vacation starts tomorrow 😁)

@bors
Copy link
Contributor

bors commented Apr 8, 2024

📌 Commit f946bf4 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2024
@bors
Copy link
Contributor

bors commented Apr 8, 2024

⌛ Testing commit f946bf4 with merge 75fd074...

@bors
Copy link
Contributor

bors commented Apr 8, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 75fd074 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 8, 2024
@bors bors merged commit 75fd074 into rust-lang:master Apr 8, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 8, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (75fd074): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.6% [0.4%, 0.9%] 4
Improvements ✅
(primary)
-1.6% [-2.7%, -0.3%] 7
Improvements ✅
(secondary)
-1.3% [-2.4%, -0.3%] 24
All ❌✅ (primary) -1.6% [-2.7%, -0.3%] 7

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.7% [-2.0%, -1.4%] 2
Improvements ✅
(secondary)
-1.5% [-1.9%, -0.9%] 11
All ❌✅ (primary) -1.7% [-2.0%, -1.4%] 2

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.3% [-3.6%, -0.3%] 16
Improvements ✅
(secondary)
-3.3% [-3.6%, -2.0%] 37
All ❌✅ (primary) -1.3% [-3.6%, -0.3%] 16

Bootstrap: 666.9s -> 668.863s (0.29%)
Artifact size: 318.48 MiB -> 318.06 MiB (-0.13%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants