Commits on Jul 7, 2024

1. Specialize TrustedLen for Iterator::unzip() …

   Don't check the capacity every time (and also for `Extend` for tuples, as this is how `unzip()` is implemented).
   
   I did this with an unsafe method on `Extend` that doesn't check for growth (`extend_one_unchecked()`). I've marked it as perma-unstable currently, although we may want to expose it in the future so collections outside of std can benefit from it. Then specialize `Extend for (A, B)` for `TrustedLen` to call it.
   
   It may seem that an alternative way of implementing this is to have a semi-public trait (`#[doc(hidden)]` public, so collections outside of core can implement it) for `extend()` inside tuples, and specialize it from collections. However, it is impossible due to limitations of `min_specialization`.
   
   A concern that may arise with the current approach is that implementing `extend_one_unchecked()` correctly must also incur implementing `extend_reserve()`, otherwise you can have UB. This is a somewhat non-local safety invariant. However, I believe this is fine, since to have actual UB you must have unsafe code inside your `extend_one_unchecked()` that makes incorrect assumption, *and* not implement `extend_reserve()`. I've also documented this requirement.

   

   ChayimFriedman2 committed Jul 7, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 54556f4
   • Browse repository at this point

   Copy the full SHA

   54556f4 View commit details

   Browse the repository at this point in the history