Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #123147

Merged
merged 24 commits into from
Mar 28, 2024
Merged

Rollup of 8 pull requests #123147

merged 24 commits into from
Mar 28, 2024

Commits on Mar 3, 2024

  1. Clarify atomic bit validity

    The previous definition used the phrase "representation", which is ambiguous given the current state of memory model nomenclature in Rust. The new wording clarifies that size and bit validity are guaranteed to match the corresponding native integer type.
    joshlf authored Mar 3, 2024
    Configuration menu
    Copy the full SHA
    59a3a5d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db34b08 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    00d21c9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fba87f6 View commit details
    Browse the repository at this point in the history
  5. Update library/core/src/sync/atomic.rs

    Co-authored-by: Taiki Endo <[email protected]>
    joshlf and taiki-e authored Mar 3, 2024
    Configuration menu
    Copy the full SHA
    c50804c View commit details
    Browse the repository at this point in the history
  6. Update library/core/src/sync/atomic.rs

    Co-authored-by: Taiki Endo <[email protected]>
    joshlf and taiki-e authored Mar 3, 2024
    Configuration menu
    Copy the full SHA
    a6e3e02 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Configuration menu
    Copy the full SHA
    804c047 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d0eb9c8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7786ee3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    86e750f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0cd9708 View commit details
    Browse the repository at this point in the history
  6. chore: fix some comments

    Signed-off-by: xiaoxiangxianzi <[email protected]>
    xiaoxiangxianzi committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    3157114 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cc4a1f4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    336ff42 View commit details
    Browse the repository at this point in the history
  9. CFI: Fix drop and drop_in_place

    Fix drop and drop_in_place by transforming self of drop and
    drop_in_place methods into Drop trait objects.
    rcvalle committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    0b86081 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    df4eec8 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#121943 - joshlf:patch-11, r=scottmcm

    Clarify atomic bit validity
    
    The previous definition used the phrase "representation", which is ambiguous given the current state of memory model nomenclature in Rust. For integer types and for `AtomicPtr<T>`, the new wording clarifies that size and bit validity are guaranteed to match the corresponding native integer type/`*mut T`. For `AtomicBool`, the new wording clarifies that size, alignment, and bit validity are guaranteed to match `bool`.
    
    Note that we use the phrase "size and alignment" rather than "layout" since the latter term also implies that the field types are the same. This isn't true - `AtomicXxx` doesn't store an `xxx`, but rather an `UnsafeCell<xxx>`. This distinction is important for some `unsafe` code, which needs to reason about the presence or absence of interior mutability in order to ensure that their code is sound (see e.g. google/zerocopy#251).
    matthiaskrgr authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    a9ed9fb View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#123075 - rcvalle:rust-cfi-fix-drop-drop-in-…

    …place, r=compiler-errors
    
    CFI: Fix drop and drop_in_place
    
    Fix drop and drop_in_place by transforming self of drop and drop_in_place methods into a Drop trait objects.
    
    This was split off from rust-lang#116404.
    
    cc `@compiler-errors` `@workingjubilee`
    matthiaskrgr authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    6464e5b View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#123101 - Bryanskiy:delegation-fixes-2, r=pe…

    …trochenkov
    
    Delegation: fix ICE on wrong `Self` instantiation
    
    fixes rust-lang#119921
    fixes rust-lang#119919
    
    There is no way to instantiate `Self` param for caller in delegation item if
    
    1. callee is a trait method && callee contains `Self` param
    2. delegation item isn't an associative item
    
    In general, we can consider `Self` param as independent type param in these cases:
    
    ```rust
    
    trait Trait {
        fn foo(_: Option<&Self>) {...}
    }
    
    reuse Trait::foo;
    // will be desugared to:
    fn foo<T: Trait>(x: Option<&T>) { Trait::foo(x) }
    ```
    
    But this requires early bound parameters support. For now, I suggest banning such cases to avoid ICE's.
    
    r? ``@petrochenkov``
    matthiaskrgr authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ae33b90 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#123130 - oli-obk:missing_type_taint, r=comp…

    …iler-errors
    
    Load missing type of impl associated constant from trait definition
    
    fixes rust-lang#123092
    
    Also does some cleanups I discovered while analyzing this issue
    matthiaskrgr authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    15fb2f2 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#123133 - xiaoxiangxianzi:master, r=fmease

    chore: fix some comments
    matthiaskrgr authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    45cec32 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#123136 - Vagelis-Prokopiou:fix/docs, r=Chri…

    …sDenton
    
    Some wording improvement
    
    "Data" is usually considered as plural uncountable, therefore "some" seems to make more sense imo.
    matthiaskrgr authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ea7789c View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#123139 - scottmcm:simpler-nonzero-get, r=jh…

    …pratt
    
    `num::NonZero::get` can be 1 transmute instead of 2
    
    Just something I noticed in passing.  No need for a `match` in here to call `unreachable_unchecked`, as `transmute_unchecked` will add the appropriate `llvm.assume` <https://rust.godbolt.org/z/W5hjeETnc>.
    matthiaskrgr authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    9c91e2c View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#123142 - Nilstrieb:nils-knows-whats-happeni…

    …ng, r=compiler-errors
    
    Let nils know about changes to target docs
    
    i'll probably expand the paths and add a message after rust-lang#121051 but i honestly don't expect that to land very soon lol, so it would be nice to get notified about changes already and watch what's happening there
    
    approve this pr if you're cool
    matthiaskrgr authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    145211e View commit details
    Browse the repository at this point in the history