Rollup of 9 pull requests #123108

matthiaskrgr · 2024-03-26T20:23:52Z

Successful merges:

Document adt_const_params feature in Unstable Book #108675 (Document adt_const_params feature in Unstable Book)
Suggest associated type bounds on problematic associated equality bounds #122120 (Suggest associated type bounds on problematic associated equality bounds)
Fix diagnostics for async block cloning #122589 (Fix diagnostics for async block cloning)
Require DerefMut and DerefPure on deref!() patterns when appropriate #122835 (Require DerefMut and DerefPure on deref!() patterns when appropriate)
In ConstructCoroutineInClosureShim, pass receiver by mut ref, not mut pointer #123049 (In ConstructCoroutineInClosureShim, pass receiver by mut ref, not mut pointer)
enable cargo miri test doctests #123055 (enable cargo miri test doctests)
unix fs: Make hurd using explicit new rather than From #123057 (unix fs: Make hurd using explicit new rather than From)
Change f16 and f128 clippy stubs to be nonpanicking #123087 (Change f16 and f128 clippy stubs to be nonpanicking)
Rename Inherited -> TypeckRootCtxt #123103 (Rename Inherited -> TypeckRootCtxt)

r? @ghost
@rustbot modify labels: rollup

Signed-off-by: onur-ozkan <[email protected]>

408c0ea ("unix time module now return result") dropped the From impl for SystemTime, breaking the hurd and horizon builds. Fixes rust-lang#123032

It turns out there is a bit of a circular dependency - I cannot add anything to `core` because Clippy fails, and I can't actually add correct Clippy implementations without new implementations from `core`. Change some of the Clippy stubs from `unimplemented!` to success values and leave a FIXME in their place to mitigate this. Fixes <rust-lang#122587>

…ompiler-errors Document `adt_const_params` feature in Unstable Book

…ound, r=compiler-errors Suggest associated type bounds on problematic associated equality bounds Fixes rust-lang#105056. TL;DR: Suggest `Trait<Ty: Bound>` on `Trait<Ty = Bound>` in Rust >=2021. ~~Blocked on rust-lang#122055 (stabilization of `associated_type_bounds`), I'd say.~~ (merged)

Fix diagnostics for async block cloning Closes rust-lang#121547 r? diagnostics

…ieril Require `DerefMut` and `DerefPure` on `deref!()` patterns when appropriate Waiting on the deref pattern syntax pr to merge r? nadrieril

…rcvr, r=oli-obk In `ConstructCoroutineInClosureShim`, pass receiver by mut ref, not mut pointer The receivers were compatible at codegen time, but did not necessarily have the same layouts due to niches, which was caught by miri. Fixes rust-lang/miri#3400 r? oli-obk

enable cargo miri test doctests This was the cleanest solution that came to my mind so far. cc `@RalfJung` Resolves rust-lang#123028

unix fs: Make hurd using explicit new rather than From 408c0ea ("unix time module now return result") dropped the From impl for SystemTime, breaking the hurd build (and probably the horizon build) Fixes rust-lang#123032

…bs, r=blyxyas Change `f16` and `f128` clippy stubs to be nonpanicking It turns out there is a bit of a circular dependency - I cannot add anything to `core` because Clippy fails, and I can't actually add correct Clippy implementations without new implementations from `core`. Change some of the Clippy stubs from `unimplemented!` to success values and leave a FIXME in their place to mitigate this. Fixes <rust-lang#122587>

…rd-name, r=oli-obk Rename `Inherited` -> `TypeckRootCtxt` `Inherited` is a confusing name. Rename it to `TypeckRootCtxt`. I don't think this needs a type MCP or anything since it's not nearly as pervasive as `FnCtxt` , for example. r? `@lcnr` `@oli-obk`

matthiaskrgr · 2024-03-26T20:24:03Z

@bors r+ rollup=never p=9

bors · 2024-03-26T20:24:05Z

📌 Commit 781b225 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-03-26T22:25:07Z

⌛ Testing commit 781b225 with merge a1b4991...

bors · 2024-03-27T00:26:26Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing a1b4991 to master...

rust-timer · 2024-03-27T00:28:58Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#108675	Document `adt_const_params` feature in Unstable Book	`ef5e401f269ef95f53d1318c5ebfa1f9db95e45a` (link)
#122120	Suggest associated type bounds on problematic associated eq…	`455e9772f264a7543786847a30a4f79fe4f26b71` (link)
#122589	Fix diagnostics for async block cloning	`33ed75c16d59e0cc1d62b5522ac00184acce3ce3` (link)
#122835	Require `DerefMut` and `DerefPure` on `deref!()` patterns w…	`1a8ef2893accd4b870ce508343fe083b8a3abe43` (link)
#123049	In `ConstructCoroutineInClosureShim`, pass receiver by mut …	`04dc2e497d206439b4d32cad67fd776ebdb47bf2` (link)
#123055	enable cargo miri test doctests	`8787db46fb1a92ef3ea0bb05180fc820e6aac21a` (link)
#123057	unix fs: Make hurd using explicit new rather than From	`7abf3e873642a542bc955609740409039a077d61` (link)
#123087	Change `f16` and `f128` clippy stubs to be nonpanicking	`a640997c3ff9edeb1e1b10563763f295025aaf9c` (link)
#123103	Rename `Inherited` -> `TypeckRootCtxt`	`bc8315054a6e6525546cb18c7fb4880e18bfc6a0` (link)

previous master: 47ecded352

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-03-27T01:43:13Z

Finished benchmarking commit (a1b4991): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	4
Regressions ❌ (secondary)	0.4%	[0.2%, 0.6%]	13
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	0.7%	[0.7%, 0.7%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.1%, 3.3%]	12
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-2.3%, -0.4%]	2
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	1.2%	[-2.3%, 3.3%]	14

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.8%, -0.4%]	7
Improvements ✅ (secondary)	-4.9%	[-6.1%, -3.5%]	3
All ❌✅ (primary)	-0.6%	[-0.8%, -0.4%]	7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.555s -> 670.032s (0.07%)
Artifact size: 315.66 MiB -> 315.61 MiB (-0.01%)

Kobzol · 2024-03-27T07:32:59Z

@rust-timer build 1a8ef28

rust-timer · 2024-03-27T13:00:36Z

Finished benchmarking commit (1a8ef28): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.4%, 2.3%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-2.3%, -0.4%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-2.3%, 2.3%]	6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	7.1%	[6.2%, 8.0%]	2
Improvements ✅ (primary)	-0.5%	[-0.6%, -0.5%]	2
Improvements ✅ (secondary)	-4.7%	[-6.4%, -3.1%]	3
All ❌✅ (primary)	-0.5%	[-0.6%, -0.5%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.555s -> 670.068s (0.08%)
Artifact size: 315.66 MiB -> 315.72 MiB (0.02%)

Mark-Simulacrum · 2024-04-01T20:05:22Z

Looks pretty likely to be continuing bimodality, rather than genuine changes. Marking as triaged.

Shadlock0133 and others added 24 commits March 15, 2024 00:21

Document adt_const_params feature in Unstable Book

17ba73c

Small tweaks to the linting code for bare trait object types

6b85f07

Update docs of hir::TypeBinding

d3d77a8

Suggest assoc ty bound on bare dyn trait in eq constraint

22b9e96

Suggest assoc ty bound on lifetime in eq constraint

3879acb

Fix diagnostics for async block cloning

0c7f8b0

Fix typos

2c433d0

Require DerefPure for patterns

b562795

Require DerefMut if deref pattern has nested ref mut binding

5fdc755

Extract helper, fix comment on DerefPure

fc1d7d2

enable cargo miri test doctests

69af113

Signed-off-by: onur-ozkan <[email protected]>

unix fs: Make hurd and horizon using explicit new rather than From

7b4e507

408c0ea ("unix time module now return result") dropped the From impl for SystemTime, breaking the hurd and horizon builds. Fixes rust-lang#123032

In ConstructCoroutineInClosureShim, pass receiver by ref, not pointer

22bc5c5

Inherited -> TypeckRootCtxt

bf7a745

Rollup merge of rust-lang#108675 - Shadlock0133:adt_const_params, r=c…

9162776

…ompiler-errors Document `adt_const_params` feature in Unstable Book

Rollup merge of rust-lang#122589 - wutchzone:121547, r=compiler-errors

20770ac

Fix diagnostics for async block cloning Closes rust-lang#121547 r? diagnostics

Rollup merge of rust-lang#122835 - compiler-errors:deref-pure, r=Nadr…

0029a11

…ieril Require `DerefMut` and `DerefPure` on `deref!()` patterns when appropriate Waiting on the deref pattern syntax pr to merge r? nadrieril

Rollup merge of rust-lang#123055 - onur-ozkan:miri-rustdoc, r=RalfJung

b8e8d65

enable cargo miri test doctests This was the cleanest solution that came to my mind so far. cc `@RalfJung` Resolves rust-lang#123028

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 27, 2024

bors merged commit a1b4991 into rust-lang:master Mar 27, 2024
12 checks passed

rustbot added this to the 1.79.0 milestone Mar 27, 2024

This was referenced Mar 27, 2024

Suggest a borrow when using dbg #120990

Merged

Pass list of defineable opaque types into canonical queries #122077

Merged

rustbot added the perf-regression Performance regression. label Mar 27, 2024

This comment has been minimized.

Sign in to view

Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Apr 1, 2024

matthiaskrgr deleted the rollup-zossklv branch September 1, 2024 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 9 pull requests #123108

Rollup of 9 pull requests #123108

matthiaskrgr commented Mar 26, 2024

matthiaskrgr commented Mar 26, 2024

bors commented Mar 26, 2024

bors commented Mar 26, 2024

bors commented Mar 27, 2024

rust-timer commented Mar 27, 2024

rust-timer commented Mar 27, 2024

Kobzol commented Mar 27, 2024

This comment has been minimized.

rust-timer commented Mar 27, 2024

Mark-Simulacrum commented Apr 1, 2024

Rollup of 9 pull requests #123108

Rollup of 9 pull requests #123108

Conversation

matthiaskrgr commented Mar 26, 2024

matthiaskrgr commented Mar 26, 2024

bors commented Mar 26, 2024

bors commented Mar 26, 2024

bors commented Mar 27, 2024

rust-timer commented Mar 27, 2024

rust-timer commented Mar 27, 2024

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Kobzol commented Mar 27, 2024

This comment has been minimized.

rust-timer commented Mar 27, 2024

Overall result: ❌✅ regressions and improvements - no action needed

Mark-Simulacrum commented Apr 1, 2024