Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vim syntax for extern crate #12271

Merged
merged 4 commits into from
Feb 15, 2014
Merged

Conversation

lilyball
Copy link
Contributor

No description provided.

@huonw
Copy link
Member

huonw commented Feb 14, 2014

Would it be possible to at least at the crate keyword to the other modes?

@lilyball
Copy link
Contributor Author

@huonw I'm not sure what you mean, to the other modes.

@huonw
Copy link
Member

huonw commented Feb 14, 2014

Editor modes: emacs, kate etc.

@lilyball
Copy link
Contributor Author

Ah. I'm not familiar with emacs/kate/etc modefiles. I don't know how to make the necessary changes.

@huonw
Copy link
Member

huonw commented Feb 14, 2014

They all have a list of keywords somewhere, presumably, and this can just be extended. (Grep for e.g. extern in them,)

@lilyball
Copy link
Contributor Author

Ok sure, I could add it as a basic keyword, but I don't know how to do the fancy vim stuff I put in here (where the keyword is marked as an error unless it's after extern).

@huonw
Copy link
Member

huonw commented Feb 14, 2014

That's fine.

@lilyball
Copy link
Contributor Author

Pushed. crate is now in the emacs and kate modefiles as well.

@huonw
Copy link
Member

huonw commented Feb 14, 2014

Could you do gedit too?

(r=me if so, and an experienced vim-er like @chrismorgan agrees with the vim changes.)

@lilyball
Copy link
Contributor Author

Pushed. @chris-morgan?

@chris-morgan
Copy link
Member

Vim stuff: LGTM.

@lilyball
Copy link
Contributor Author

Thanks @chris-morgan and @huonw.

@bors bors closed this Feb 15, 2014
@bors bors merged commit 33b2b8a into rust-lang:master Feb 15, 2014
@lilyball lilyball deleted the vim-extern-crate branch February 15, 2014 20:28
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2022
fix rust-lang#12227 Type mismatch error shown

add box expectation hint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants