Ensure an error is raised on infinite recursion #12247

flaper87 · 2014-02-13T20:19:46Z

huonw · 2014-02-13T20:51:40Z

src/test/compile-fail/issue-8727.rs

+
+struct Data(~Option<Data>);
+
+fn generic<T>( _ : ~[(Data,T)] ) {let rec : ~[(Data,(bool,T))] = ~[]; generic( rec ); } //~ ERROR overly deep expansion of inlined function


What about some newlines?

I think that we're running tidy over tests now (or at least I think there was a PR for that), so it may be required in the future to shorten this line.

There's a test directive to allow long lines, but I don't recall what it is off hand.

I was having some issues with making the printed, multi-line error match the error in the comment, which means this test kept failing.

I'd be ok to re-factor this patch or proposa a new one that makes it multi-line if that's needed.

…albasi fix: ignore impls with `#[rustc_reservation_impl]` Fixes rust-lang#12247 Fixes rust-lang#14279 Currently core has two blanket impls for `From`: `impl<T> From<T> for T` and `impl<T> From<!> for T`. These are conflicting and thus chalk cannot uniquely solve `S: From<?0>` for any type `S`. The latter impl is actually a reservation impl and should not be considered during trait selection. More generally, impls attributed with perma-unstable `#[rustc_reservation_impl]` attribute should be disregarded except for coherence checks. See rust-lang#64631 and rust-lang#64715 for details. I chose to entirely ignore them in hir-ty because we don't do coherence checks.

Ensure an error is raised on infinite recursion

316474f

huonw reviewed Feb 13, 2014
View reviewed changes

alexcrichton closed this in 2f8dbf2 Feb 14, 2014

flaper87 deleted the issue-8727 branch March 11, 2014 09:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure an error is raised on infinite recursion #12247

Ensure an error is raised on infinite recursion #12247

flaper87 commented Feb 13, 2014

huonw Feb 13, 2014

alexcrichton Feb 13, 2014

brson Feb 14, 2014

flaper87 Feb 14, 2014


		struct Data(~Option<Data>);

		fn generic<T>( _ : ~[(Data,T)] ) {let rec : ~[(Data,(bool,T))] = ~[]; generic( rec ); } //~ ERROR overly deep expansion of inlined function

Ensure an error is raised on infinite recursion #12247

Ensure an error is raised on infinite recursion #12247

Conversation

flaper87 commented Feb 13, 2014

huonw Feb 13, 2014

Choose a reason for hiding this comment

alexcrichton Feb 13, 2014

Choose a reason for hiding this comment

brson Feb 14, 2014

Choose a reason for hiding this comment

flaper87 Feb 14, 2014

Choose a reason for hiding this comment