mir-opt: always run tests for the current target #122295
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
|
I do not think this fixes the issue in question. If the host is not x86_64 with unwinding, the test in question is still not going to be blessed (aarch64 with unwinding is an increasingly common development platform, we really should not ignore it). |
|
Hm, it fixes the inconsistency between bless and not bless, but indeed it doesn't ensure we bless all the mir-opt tests that can come up in CI. Should we also add more target to the bless list? |
|
If we must change the bless list, I'd prefer that we change which targets are used so that we do not have any test output files that go un-blessed. But in this case specific case, I wonder if we get the test in question blessed by changing its |
…et, r=Mark-Simulacrum mir-opt: always run tests for the current target Currently, `./x.py test tests/mir-opt` runs only the tests for the current target, and `./x.py test tests/mir-opt --bless` runs tests for a representative set of targets. That representative set does not include the current target however, which means `--bless` can succeed when tests fail without it. This PR ensures we run the current target always. Fixes rust-lang#122292 cc `@RalfJung`
Yeah I suspect it could be But either way I think this PR is still valuable, we should ensure we always bless at least the target that gets tested without |
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#119411 (Add as_(mut_)ptr and as_(mut_)slice to raw array pointers) - rust-lang#122248 (Respect stage0 sysroot when compiling rmake.rs with COMPILETEST_FORCE_STAGE0) - rust-lang#122295 (mir-opt: always run tests for the current target) - rust-lang#122574 (Register LLVM handlers for bad-alloc / OOM) - rust-lang#122608 (Move check-cfg diagnostic logic into a separate file) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#122295 - Nadrieril:mir-opt-run-current-target, r=Mark-Simulacrum mir-opt: always run tests for the current target Currently, `./x.py test tests/mir-opt` runs only the tests for the current target, and `./x.py test tests/mir-opt --bless` runs tests for a representative set of targets. That representative set does not include the current target however, which means `--bless` can succeed when tests fail without it. This PR ensures we run the current target always. Fixes rust-lang#122292 cc ``@RalfJung``
…=Nadrieril Remove some only- clauses from mir-opt tests Derived from rust-lang#122295 Many of these tests were originally codegen tests, and MIR is more trivially portable than LLVM IR. We simply don't need to restrict the platform in most cases. r? Nadrieril
…=Nadrieril Remove some only- clauses from mir-opt tests Derived from rust-lang#122295 Many of these tests were originally codegen tests, and MIR is more trivially portable than LLVM IR. We simply don't need to restrict the platform in most cases. r? Nadrieril
…adrieril Remove some only- clauses from mir-opt tests Derived from rust-lang#122295 Many of these tests were originally codegen tests, and MIR is more trivially portable than LLVM IR. We simply don't need to restrict the platform in most cases. r? Nadrieril
…adrieril Remove some only- clauses from mir-opt tests Derived from rust-lang#122295 Many of these tests were originally codegen tests, and MIR is more trivially portable than LLVM IR. We simply don't need to restrict the platform in most cases. r? Nadrieril
Remove some only- clauses from mir-opt tests Derived from rust-lang/rust#122295 Many of these tests were originally codegen tests, and MIR is more trivially portable than LLVM IR. We simply don't need to restrict the platform in most cases. r? Nadrieril
Remove some only- clauses from mir-opt tests Derived from rust-lang/rust#122295 Many of these tests were originally codegen tests, and MIR is more trivially portable than LLVM IR. We simply don't need to restrict the platform in most cases. r? Nadrieril
Remove some only- clauses from mir-opt tests Derived from rust-lang/rust#122295 Many of these tests were originally codegen tests, and MIR is more trivially portable than LLVM IR. We simply don't need to restrict the platform in most cases. r? Nadrieril
Currently,
./x.py test tests/mir-optruns only the tests for the current target, and./x.py test tests/mir-opt --blessruns tests for a representative set of targets. That representative set does not include the current target however, which means--blesscan succeed when tests fail without it. This PR ensures we run the current target always.Fixes #122292
cc @RalfJung