Rollup of 10 pull requests

[jhpratt]

Successful merges:

• Increase visibility of join_path and split_paths #119748 (Increase visibility of join_path and split_paths)
• Have String use SliceIndex impls from str #120291 (Have String use SliceIndex impls from str)
• Two diagnostic things #121723 (Two diagnostic things)
• Changing some attributes to only_local. #121740 (Changing some attributes to only_local.)
• Deeply normalize obligations in refining_impl_trait #121745 (Deeply normalize obligations in refining_impl_trait)
• Restore the standard library review rotation to its former glory #121748 (Restore the standard library review rotation to its former glory)
• Implement unwind safety for Condvar on all platforms  #121768 (Implement unwind safety for Condvar on all platforms )
• Fix typo in rustc_passes/messages.ftl #121777 (Fix typo in rustc_passes/messages.ftl)
• Document potential memory leak in unbounded channel #121778 (Document potential memory leak in unbounded channel)
• Remove unused diagnostic struct #121779 (Remove unused diagnostic struct)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[jhpratt]

@bors r+ rollup=never p=10

[bors]

📌 Commit 698cec8 has been approved by jhpratt

It is now in the queue for this repository.

[bors]

⌛ Testing commit 698cec8 with merge 71a7b66...

[bors]

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 71a7b66 to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#119748	Increase visibility of join_path and split_paths	d9cead8322f88cec40eba44d70bee43ff92c3568 (link)
#120291	Have String use SliceIndex impls from str	bcc69c9ff8b735b8a40b0e1a81ab1dc46def4420 (link)
#121723	Two diagnostic things	35b3ef9cabe2bf44cb86c2f791ee045bfe91956a (link)
#121740	Changing some attributes to only_local.	5e3b66d71bc9ac741761115cc223b28c7f182b02 (link)
#121745	Deeply normalize obligations in refining_impl_trait	a2f01faa00d6e4cfd8b4f0b54afe3ecdfb90190e (link)
#121748	Restore the standard library review rotation to its former …	d009b50d480c4ece709a479822d3d7e1a245abba (link)
#121768	Implement unwind safety for Condvar on all platforms	c4904fef4b23c7d128551ad5faf5d874d38b15ac (link)
#121777	Fix typo in rustc_passes/messages.ftl	1f65210c14a4435c405705db4e3d353a146464a6 (link)
#121778	Document potential memory leak in unbounded channel	fe221592604963850d045b7a64d0e6487fc00d21 (link)
#121779	Remove unused diagnostic struct	092558ca70fad9d1a78f18a100b037ab46e7d5df (link)

previous master: d3d145ea1c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (71a7b66): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.6%, 0.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.6%, -0.3%]	2
Improvements ✅ (secondary)	-1.9%	[-2.4%, -1.5%]	2
All ❌✅ (primary)	-0.1%	[-0.6%, 0.6%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	6.9%	[2.6%, 14.3%]	3
Regressions ❌ (secondary)	4.9%	[3.7%, 6.0%]	2
Improvements ✅ (primary)	-4.8%	[-5.4%, -4.3%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.2%	[-5.4%, 14.3%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.9%	[-0.9%, -0.9%]	1

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.2%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.7%, -0.0%]	30
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.7%, 0.2%]	36

Bootstrap: 650.923s -> 650.304s (-0.10%)
Artifact size: 311.19 MiB -> 311.18 MiB (-0.00%)

[jhpratt]

Results appear to be random noise.

@rustbot label pref-regression-triaged

[Mark-Simulacrum]

I disagree, the Cargo change looks to be both above any noise floor and does not show signs of reverting. However, it's not significant enough (given limit to just Cargo) to investigate further.